Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert stream base #1140

Closed
wants to merge 16 commits into from
Closed

Revert stream base #1140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d9f210a
Revert "tls_wrap: proxy handle methods in prototype"
piscisaureus Mar 13, 2015
995f4f4
Revert "stream_base: WriteWrap::New/::Dispose"
piscisaureus Mar 13, 2015
5f8b84d
Revert "tls: do not leak WriteWrap objects"
piscisaureus Mar 13, 2015
c4f8fb8
Revert "src: add missing Context::Scope"
piscisaureus Mar 13, 2015
3b2e4db
Revert "tls_wrap: do not hold persistent ref to parent"
piscisaureus Mar 13, 2015
ad27281
Revert "js_stream: fix leak of instances"
piscisaureus Mar 13, 2015
4dba51b
Revert "stream_wrap: add HandleScope's in uv callbacks"
piscisaureus Mar 13, 2015
ad827c6
Revert "tty: do not add `shutdown` method to handle"
piscisaureus Mar 13, 2015
ed716cc
Revert "tls: accept empty `net.Socket`s"
piscisaureus Mar 13, 2015
c3941bf
Revert "src: fix --without-ssl build"
piscisaureus Mar 13, 2015
c19427d
Revert "stream_base: `.writev()` has limited support"
piscisaureus Mar 13, 2015
e4459aa
Revert "tls: proxy `handle.reading` back to parent handle"
piscisaureus Mar 13, 2015
0babace
Revert "tls: fix typo `handle._reading` => `handle.reading`"
piscisaureus Mar 13, 2015
ad9294e
Revert "stream_base: remove static JSMethod declarations"
piscisaureus Mar 13, 2015
98eb636
Revert "streams: introduce StreamWrap and JSStream"
piscisaureus Mar 13, 2015
969221a
Revert "stream_base: introduce StreamBase"
piscisaureus Mar 13, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 0 additions & 118 deletions lib/_stream_wrap.js
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions lib/_tls_legacy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,11 @@ function onCryptoStreamFinish() {
// Generate close notify
// NOTE: first call checks if client has sent us shutdown,
// second call enqueues shutdown into the BIO.
if (this.pair.ssl.shutdownSSL() !== 1) {
if (this.pair.ssl.shutdown() !== 1) {
if (this.pair.ssl && this.pair.ssl.error)
return this.pair.error();

this.pair.ssl.shutdownSSL();
this.pair.ssl.shutdown();
}

if (this.pair.ssl && this.pair.ssl.error)
Expand Down
Loading