test: remove unused args and comparison fix. #11396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
approved these changes
Feb 15, 2017
There was a problem hiding this comment.
Changes LGTM. Can you format the commit message according to our guidelines?
|
@targos thanks for answer. I add subsystem name to my commit message and check length and format of the message, as I see it follow the guidelines. What I missed? |
|
|
Remove unused arguments and change non-strict comparison to the strict one in test.
sashashakun
changed the title
hiroppy
approved these changes
Feb 15, 2017
jasnell
approved these changes
Feb 15, 2017
|
Not sure what happens, as I see here all CI jobs are finished successfully. What I miss? |
|
@sashashakun Nothing to worry about. There is a bug with the reporter for |
cjihrig
approved these changes
Feb 16, 2017
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Feb 17, 2017
Remove unused arguments and change non-strict comparison to the strict one in test. PR-URL: nodejs#11396 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 55d202a. |
addaleax
pushed a commit
that referenced
this pull request
Feb 22, 2017
Remove unused arguments and change non-strict comparison to the strict one in test. PR-URL: #11396 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Remove unused arguments and change non-strict comparison to the strict one in test. PR-URL: #11396 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Remove unused arguments and change non-strict comparison to the strict one in test. PR-URL: #11396 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Remove unused arguments and change non-strict comparison to the strict one in test. PR-URL: #11396 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Remove unused arguments and change non-strict comparison to the strict one in test. PR-URL: #11396 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused arguments and change non-strict comparison
to the strict one.
/cc @Trott
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test