test: cover dgram socket close during cluster bind #11292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Feb 10, 2017
|
CI: https://ci.nodejs.org/job/node-test-pull-request/6375/ EDIT: New CI with Windows skip: https://ci.nodejs.org/job/node-test-pull-request/6393/ |
cjihrig
force-pushed
the
close-during-bind
branch
from
5b5bfaf
to
b4364c3
Compare
|
@nodejs/build seeing more build failures here. They all seem to be on ubuntu1604-arm64. |
When a non-exclusive dgram socket is bound from a cluster worker, it attempts to get a handle from the cluster module. This commit adds coverage for the case where the socket is closed while querying the cluster module for a handle. PR-URL: nodejs#11292 Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig
force-pushed
the
close-during-bind
branch
from
b4364c3
to
ac602a2
Compare
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 16, 2017
When a non-exclusive dgram socket is bound from a cluster worker, it attempts to get a handle from the cluster module. This commit adds coverage for the case where the socket is closed while querying the cluster module for a handle. PR-URL: nodejs#11292 Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
that referenced
this pull request
Feb 22, 2017
When a non-exclusive dgram socket is bound from a cluster worker, it attempts to get a handle from the cluster module. This commit adds coverage for the case where the socket is closed while querying the cluster module for a handle. PR-URL: #11292 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
|
Requires the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a non-exclusive dgram socket is bound from a cluster worker, it attempts to get a handle from the
clustermodule. This commit adds coverage for the case where the socket isclosed while querying the
clustermodule for a handle.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)