v7.x backport: tools: update ESLint to current version #11009
Conversation
Formatting changes for upcoming linter update. PR-URL: nodejs#10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade. PR-URL: nodejs#10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
ESLint `indent` rule now has options that duplicate functionality in our custom `align-function-arguments` rule. Remove `align-function-arguments` custom rule. PR-URL: nodejs#10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
The `no-useless-regex-char-class-escape` custom lint rule was introduced as a less aggressive alternative to some enhancements that were introduced into ESLint. Those enhancements were blocking us from updating ESLint. However, they have since been relaxed and the custom rule is no longer needed. Remove it. PR-URL: nodejs#10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
nodejs-github-bot
added
module
|
If I understand correctly, @italoacasas has cherry-picked these to the necessary branch and this backport is no longer needed. Re-open and/or comment if I'm mistaken. Thanks! Closing. |
|
I hope he got my fix for
I'll check. |
|
@italoacasas #9299 is missing from v7.x-staging. |
|
@sam-github that commit was part of v7.1.0, I'm missing something here? |
|
Maybe I am, @italoacasas https://github.com/nodejs/node/tree/master/tools/eslint/node_modules/.bin has no https://github.com/nodejs/node/tree/v7.x-staging/tools/eslint/node_modules/.bin does have one, and it points to a non-existent file. It looks to be because #10771 is missing, not #9299. Sorry, I had to remove it twice, it keeps getting added back. This means that the commits on master aren't on staging. Just FYI. I don't know if they are intended to be, or not, at this point. |
|
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport |
Backport of #10561