Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Revert add option to use node in path #10613

Closed
wants to merge 1 commit into from
Closed

test: Revert add option to use node in path #10613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions tools/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
import copy

from os.path import join, dirname, abspath, basename, isdir, exists
from distutils.spawn import find_executable
from datetime import datetime
from Queue import Queue, Empty

Expand Down Expand Up @@ -866,14 +865,6 @@ def __init__(self, workspace, buildspace, verbose, vm, args, expect_fail,
self.repeat = repeat

def GetVm(self, arch, mode):
parser = BuildOptions()
(options, args) = parser.parse_args()
if not ProcessOptions(options):
parser.print_help()
return 1
if options.path:
name = find_executable("node")
return name
if arch == 'none':
name = 'out/Debug/node' if mode == 'debug' else 'out/Release/node'
else:
Expand Down Expand Up @@ -1394,8 +1385,6 @@ def BuildOptions():
result.add_option('--repeat',
help='Number of times to repeat given tests',
default=1, type="int")
result.add_option('--path',
help='Use node in the path rather than out/Release', default=False, action="store_true")
return result


Expand Down