Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: avoid out-of-bounds arguments index access #10569

Merged
merged 1 commit into from
Jan 5, 2017
Merged

util: avoid out-of-bounds arguments index access #10569

merged 1 commit into from
Jan 5, 2017

Commits on Jan 5, 2017

  1. util: avoid out-of-bounds arguments index access 

    This updates util.inspect() to avoid accessing out-of-range indices of
the `arguments` object, which is known to cause optimization bailout.

Based on an average of 10 runs of the benchmark in
`benchmark/util/inspect.js`, this change improves the performance of
`util.inspect` by about 10%.

Relates to nodejs#10323

PR-URL: nodejs#10569
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @not-an-aardvark
    not-an-aardvark committed Jan 5, 2017
    Configuration menu
    Copy the full SHA
    26f2a6e View commit details
    Browse the repository at this point in the history