Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test fix: Use assert.strictEqual instead of assert.equal and assert.ok #10420

Closed
wants to merge 1 commit into from
Closed

test fix: Use assert.strictEqual instead of assert.equal and assert.ok #10420

wants to merge 1 commit into from

Conversation

navulirs
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Dec 23, 2016
@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Dec 23, 2016
@mscdex
Copy link
Contributor

mscdex commented Dec 23, 2016

Commit message should be formatted according to the contributing guide. The correct subsystem in this case is test.

@navulirs
Copy link
Contributor Author

Hi I did amend the commit and force push with "test: Use assert.strictEqual instead of assert.equal and assert.ok" - this PR's title still shows as test fix: instead of just test: . i'm not sure how to get this corrected.

This was referenced Dec 24, 2016
Closed
Closed
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 24, 2016
@Trott
Copy link
Member

Trott commented Dec 24, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5570/

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 24, 2016
@navulirs @Trott
test: refactor test-child-process-stdin
0304848 
Use assert.strictEqual instead of assert.equal and assert.ok

PR-URL: nodejs#10420
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Dec 24, 2016

Landed in 0304848.
Thanks for the contribution! 🎉

@Trott Trott closed this Dec 24, 2016
targos pushed a commit that referenced this pull request Dec 26, 2016
@navulirs @targos
test: refactor test-child-process-stdin
26aa148 
Use assert.strictEqual instead of assert.equal and assert.ok

PR-URL: #10420
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 27, 2016
Merged
targos pushed a commit that referenced this pull request Dec 28, 2016
@navulirs @targos
test: refactor test-child-process-stdin
d1e2257 
Use assert.strictEqual instead of assert.equal and assert.ok

PR-URL: #10420
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
@navulirs @evanlucas
test: refactor test-child-process-stdin
a018c60 
Use assert.strictEqual instead of assert.equal and assert.ok

PR-URL: #10420
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
@navulirs @evanlucas
test: refactor test-child-process-stdin
d3bef30 
Use assert.strictEqual instead of assert.equal and assert.ok

PR-URL: #10420
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@navulirs @MylesBorins
test: refactor test-child-process-stdin
0e0dc86 
Use assert.strictEqual instead of assert.equal and assert.ok

PR-URL: #10420
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@navulirs @MylesBorins
test: refactor test-child-process-stdin
5aec663 
Use assert.strictEqual instead of assert.equal and assert.ok

PR-URL: #10420
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@navulirs @MylesBorins
test: refactor test-child-process-stdin
fb9a0ad 
Use assert.strictEqual instead of assert.equal and assert.ok

PR-URL: #10420
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@navulirs @mscdex @Trott @jasnell @addaleax @cjihrig @targos @nodejs-github-bot