Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix failing test-fs-access while uid 0 #1037

Closed

Conversation

jbergstroem
Copy link
Member

Superusers can open files with W_OK permission even though their mode is set to 0444. Patch originally from nodejs/node-v0.x-archive@28d0cbbd.

Fixes #1031.

/R=@cjihrig

Superusers can open files with W_OK permission even though their
mode is set to 0444. Patch originally from nodejs/node-v0.x-archive@28d0cbbd.

Fixes nodejs#1031.

PR-Url: nodejs#1031
cjihrig pushed a commit that referenced this pull request Mar 3, 2015
Superusers can open files with W_OK permission even though their
mode is set to 0444. This commit makes the test attempt to change
its uid to nobody on non-Windows platforms. Patch originally from
nodejs/node-v0.x-archive@28d0cbbd.

Fixes: #1031
PR-URL: #1037
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@cjihrig
Copy link
Contributor

cjihrig commented Mar 3, 2015

Thanks. Landed in fd3ea29

@cjihrig cjihrig closed this Mar 3, 2015
@rvagg rvagg mentioned this pull request Mar 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants