Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add known_issues test for #6287 #10272

Closed
wants to merge 1 commit into from

Conversation

AnnaMag
Copy link
Member

@AnnaMag AnnaMag commented Dec 14, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

tests

Description of change

A test addressing #6287:
Deleting property in the vm context has no effect
is added to the known_issues directory.
It will be fixed with the 5.5 V8 API changes

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Dec 14, 2016
@fhinkel
Copy link
Member

fhinkel commented Dec 16, 2016

Is this test "moved" or newly added?

@AnnaMag
Copy link
Member Author

AnnaMag commented Dec 16, 2016

added- comment fixed. thanks!

const assert = require('assert');
const vm = require('vm');

var context = vm.createContext();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be const?

const res = vm.runInContext(`
this.x = 'prop';
delete this.x;
Object.getOwnPropertyDescriptor(this, "x");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use single quotes with x here?

@@ -0,0 +1,15 @@
'use strict';
// Refs:https://github.com/nodejs/node/issues/6287
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space after the colon please.

Deleting property in the vm context has no effect
as reported in nodejs#6287
The test is moved to the known_issues and will be fixed
with the 5.5 V8 API changes.
@AnnaMag
Copy link
Member Author

AnnaMag commented Dec 16, 2016

@cjihrig, done

Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@italoacasas
Copy link
Contributor

Landed 0d3ac89

Thanks @AnnaMag

italoacasas pushed a commit that referenced this pull request Dec 18, 2016
Deleting property in the vm context has no effect
as reported in #6287
The test is moved to the known_issues and will be fixed
with the 5.5 V8 API changes.

PR-URL: #10272
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 20, 2016
Deleting property in the vm context has no effect
as reported in nodejs#6287
The test is moved to the known_issues and will be fixed
with the 5.5 V8 API changes.

PR-URL: nodejs#10272
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@italoacasas italoacasas mentioned this pull request Dec 20, 2016
cjihrig pushed a commit that referenced this pull request Dec 20, 2016
Deleting property in the vm context has no effect
as reported in #6287
The test is moved to the known_issues and will be fixed
with the 5.5 V8 API changes.

PR-URL: #10272
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
Deleting property in the vm context has no effect
as reported in #6287
The test is moved to the known_issues and will be fixed
with the 5.5 V8 API changes.

PR-URL: #10272
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
Deleting property in the vm context has no effect
as reported in #6287
The test is moved to the known_issues and will be fixed
with the 5.5 V8 API changes.

PR-URL: #10272
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2017
@AnnaMag AnnaMag deleted the vm-tests_known_issues branch January 25, 2017 14:58
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
Deleting property in the vm context has no effect
as reported in #6287
The test is moved to the known_issues and will be fixed
with the 5.5 V8 API changes.

PR-URL: #10272
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants