Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: ICU 58.2 bump #10206

Closed
wants to merge 2 commits into from
Closed

deps: ICU 58.2 bump #10206

wants to merge 2 commits into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Dec 9, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

Description of change

No feature changes. Bug fixes.

Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

  • CLDR 30.0.3 ( was 30.0.2)
  • Timezone 2016j ( was 2016g )

@srl295 srl295 added wip Issues and PRs that are still a work in progress. i18n-api Issues and PRs related to the i18n implementation. labels Dec 9, 2016
@srl295 srl295 self-assigned this Dec 9, 2016
Copy link
Member Author

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: actual impact is smaller than what's here due to whitespace when it actually lands. I'll see if I can figure out how to reduce the whitespace churn here.

Guess i need to 'land' the PR on a branch with am … fix-whitespace .. and force push that branch back

@srl295
Copy link
Member Author

srl295 commented Dec 9, 2016

58.2 was released http://site.icu-project.org/download/58

@srl295 srl295 removed the wip Issues and PRs that are still a work in progress. label Dec 10, 2016
@Fishrock123 Fishrock123 reopened this Dec 12, 2016
@Fishrock123
Copy link
Contributor

Sorry about that.

@srl295 should this be backported to LTS?

@mhdawson
Copy link
Member

Removing the whitespace changes would make it a lot easier to review.

No feature changes. Bug fixes.

Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )
* update configure to new path

PR-URL: nodejs#10206
@srl295
Copy link
Member Author

srl295 commented Dec 14, 2016

@Fishrock123 yes, i think it should be backported
@mhdawson try it now - should be a lot easier to review.

I used curl -L https://github.com/nodejs/node/pull/10206.patch | git am --whitespace=fix to "land" it on a new branch, the pushed that back. Is there an easier way to do this? If I can integrate it into the "howto upgrade ICU docs", we can make this the same way for the future.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gibfahn
Copy link
Member

gibfahn commented Dec 23, 2016

@mhdawson To review without the whitespace changes you can just add ?w=1 to the end of the URL.

@srl295 I think fixing the whitespace issues is the right way to go, if people find it messy they can use the ?w=1 trick. Obviously hopefully once the issues have been fixed once then it won't continue to be a problem.

@srl295
Copy link
Member Author

srl295 commented Dec 23, 2016 via email

@jasnell
Copy link
Member

jasnell commented Dec 27, 2016

@srl295
Copy link
Member Author

srl295 commented Dec 29, 2016

landed in 68f004f and c830179

@srl295 srl295 closed this Dec 29, 2016
@srl295 srl295 deleted the icu4c-58.2 branch December 29, 2016 22:32
srl295 added a commit that referenced this pull request Dec 29, 2016
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
srl295 added a commit that referenced this pull request Dec 29, 2016
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@srl295 srl295 mentioned this pull request Jan 16, 2017
4 tasks
srl295 added a commit to srl295/node that referenced this pull request Jan 18, 2017
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: nodejs#10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
srl295 added a commit to srl295/node that referenced this pull request Jan 18, 2017
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: nodejs#10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 20, 2017
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 20, 2017
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2017
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants