Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure on Solaris 10 with Node v7 #9856

Closed
ptribble opened this issue Nov 30, 2016 · 3 comments
Closed

Build failure on Solaris 10 with Node v7 #9856

ptribble opened this issue Nov 30, 2016 · 3 comments
Labels
libuv Issues and PRs related to the libuv dependency or the uv binding. smartos Issues and PRs related to the SmartOS platform.

Comments

@ptribble
Copy link

  • Version: v7.2.0
  • Platform: SunOS 5.10
  • Subsystem: build

Node v7 (tested v7.2.0) fails to build on Solaris 10.

The problem is in deps/uv/src/unix/sunos.c, where the function uv__set_phys_addr needs to be guarded with SUNOS_NO_IFADDRS. (It's only called from uv_interface_addresses,in code guarded by SUNOS_NO_IFADDRS, so the whole function can be guarded.) See attached patch.

node-v7-sunos-patch.txt
@silverwind
Copy link
Contributor

libuv is a dependency managed outside this repository. Can you move this issue to the libuv repository, possibly in the form of a pull request?

@silverwind silverwind added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Nov 30, 2016
@mscdex mscdex added the smartos Issues and PRs related to the SmartOS platform. label Nov 30, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Dec 1, 2016

Closing, as this belongs in libuv.

@cjihrig cjihrig closed this as completed Dec 1, 2016
bnoordhuis added a commit to bnoordhuis/libuv that referenced this issue Dec 1, 2016
@bnoordhuis
sunos: fix SUNOS_NO_IFADDRS build
2ba1b6e 
Don't compile uv__set_phys_addr() if SUNOS_NO_IFADDRS is defined,
it has been reported to break the build on Solaris 10.

Bug introduced in commit d75e334 ("sunos: set phys_addr of
interface_address using ARP") from last June.

Fixes: nodejs/node#9856
@bnoordhuis bnoordhuis mentioned this issue Dec 1, 2016
Closed
@bnoordhuis
Copy link
Member

libuv/libuv#1155

saghul pushed a commit to libuv/libuv that referenced this issue Jan 18, 2017
@bnoordhuis @saghul
sunos: fix SUNOS_NO_IFADDRS build
36ba7eb 
Don't compile uv__set_phys_addr() if SUNOS_NO_IFADDRS is defined,
it has been reported to break the build on Solaris 10.

Bug introduced in commit d75e334 ("sunos: set phys_addr of
interface_address using ARP") from last June.

Fixes: nodejs/node#9856
PR-URL: #1155
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
cjihrig added a commit that referenced this issue Feb 9, 2017
@cjihrig
deps: upgrade libuv to 1.11.0
8514269 
Fixes: #10165
Fixes: #9856
Fixes: #10607
Fixes: #11104
PR-URL: #11094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas pushed a commit that referenced this issue Feb 13, 2017
@cjihrig @italoacasas
deps: upgrade libuv to 1.11.0
b614b59 
Fixes: #10165
Fixes: #9856
Fixes: #10607
Fixes: #11104
PR-URL: #11094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas pushed a commit to italoacasas/node that referenced this issue Feb 14, 2017
@cjihrig @italoacasas
deps: upgrade libuv to 1.11.0
445794e 
Fixes: nodejs#10165
Fixes: nodejs#9856
Fixes: nodejs#10607
Fixes: nodejs#11104
PR-URL: nodejs#11094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
krydos pushed a commit to krydos/node that referenced this issue Feb 25, 2017
@cjihrig @krydos
deps: upgrade libuv to 1.11.0
fc83c7f 
Fixes: nodejs#10165
Fixes: nodejs#9856
Fixes: nodejs#10607
Fixes: nodejs#11104
PR-URL: nodejs#11094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this issue May 18, 2017
@cjihrig @MylesBorins
deps: upgrade libuv to 1.11.0
8347b9b 
Fixes: #10165
Fixes: #9856
Fixes: #10607
Fixes: #11104
PR-URL: #11094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this issue May 18, 2017
@cjihrig @MylesBorins
deps: upgrade libuv to 1.11.0
a12cdf0 
Fixes: #10165
Fixes: #9856
Fixes: #10607
Fixes: #11104
PR-URL: #11094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this issue May 18, 2017
@cjihrig @MylesBorins
deps: upgrade libuv to 1.11.0
e714243 
Fixes: #10165
Fixes: #9856
Fixes: #10607
Fixes: #11104
PR-URL: #11094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
andrew749 pushed a commit to michielbaird/node that referenced this issue Jul 19, 2017
@cjihrig @andrew749
deps: upgrade libuv to 1.11.0
4e71814 
Fixes: nodejs/node#10165
Fixes: nodejs/node#9856
Fixes: nodejs/node#10607
Fixes: nodejs/node#11104
PR-URL: nodejs/node#11094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
libuv Issues and PRs related to the libuv dependency or the uv binding. smartos Issues and PRs related to the SmartOS platform.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mscdex @silverwind @bnoordhuis @ptribble @cjihrig