Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-cluster-worker-init on Raspberry Pi 1 #8700

Closed
Trott opened this issue Sep 21, 2016 · 2 comments
Closed

Investigate flaky test-cluster-worker-init on Raspberry Pi 1 #8700

Trott opened this issue Sep 21, 2016 · 2 comments
Labels
arm Issues and PRs related to the ARM platform. cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Sep 21, 2016

https://ci.nodejs.org/job/node-test-binary-arm/3930/RUN_SUBSET=3,label=pi1-raspbian-wheezy/console

not ok 24 parallel/test-cluster-worker-init
# 
# assert.js:85
#   throw new assert.AssertionError({
#   ^
# AssertionError: message not received
#     at Timeout._onTimeout (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-cluster-worker-init.js:14:5)
#     at Timer.unrefdHandle (timers.js:460:14)

/cc @cjihrig
@Trott Trott added cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. arm Issues and PRs related to the ARM platform. labels Sep 21, 2016
@imyller
Copy link
Member

imyller commented Sep 21, 2016

Possibly resolved. PR coming soon.

Stress test CI with pi1 looks promising:
https://ci.nodejs.org/job/node-stress-single-test-pi1-binary/label=pi1-raspbian-wheezy/14/

@imyller imyller mentioned this issue Sep 21, 2016
Closed
3 tasks
imyller added a commit to imyller/node that referenced this issue Sep 21, 2016
@imyller
test: fix test-cluster-worker-init.js flakyness
0dbbdc0 
Update test to match current test guidelines and use common.mustCall
instead of unref'd timer.

Fixes: nodejs#8700
@imyller
Copy link
Member

imyller commented Sep 22, 2016 •
edited
Loading

@Trott IMHO it was a good idea to open an issue for investigating this one. 👍

I know there are more testing issues causing arm-fanned CI group failures. Maybe you could open "investigate" issues for those as well. More people can jump in to sort them out.

jasnell pushed a commit that referenced this issue Sep 29, 2016
@imyller @jasnell
test: fix test-cluster-worker-init.js flakyness
9a6b779 
Update test to match current test guidelines and use common.mustCall
instead of unref'd timer.

PR-URL: #8703
Fixes: #8700
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Fishrock123 pushed a commit that referenced this issue Oct 11, 2016
@imyller @Fishrock123
test: fix test-cluster-worker-init.js flakyness
5540e3d 
Update test to match current test guidelines and use common.mustCall
instead of unref'd timer.

PR-URL: #8703
Fixes: #8700
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this issue Nov 18, 2016
@imyller
test: fix test-cluster-worker-init.js flakyness
cec5e36 
Update test to match current test guidelines and use common.mustCall
instead of unref'd timer.

PR-URL: #8703
Fixes: #8700
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix test-cluster-worker-init.js flakyness imyller/node
2 participants
@Trott @imyller