Investigate flaky test-fs-watch-recursive on OS X #8511
Labels
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
fs
Issues and PRs related to the fs subsystem / file system.
macos
Issues and PRs related to the macOS platform / OSX.
test
Issues and PRs related to the tests.
Comments
Trott
added
fs
|
Still seeing this (e.g., https://ci.nodejs.org/job/node-test-commit-osx/5733/nodes=osx1010/console). See it from time to time locally too. |
|
Another one: https://ci.nodejs.org/job/node-test-commit-osx/5813/nodes=osx1010/console I see it locally from time to time, but not when I'm trying to make it fail (by running it over and over). Would appreciate any insights on making it fail on demand. |
|
spotting this more often locally also. It's already happened three or four times today. |
|
Now that 60a78ae has landed, I am able to duplicate this failure like this on OS X (after increasing my Fix coming shortly. I'm optimistic that what causes the issue above is what causes it in general. |
Trott
added a commit
to Trott/io.js
that referenced
this issue
Oct 26, 2016
The test was sometimes timing out due to a race condition. In OS X, events for `fs.watch()` might only start showing up after a delay. This is a limitation of the operating system. To work around that, there was a timer in the test that delayed the writing of the file by 100ms. However, sometimes that was not enough, and so the event never fired, and the test timed out. Change the timer to an interval so that it fires repeatedly until it is picked up. This change only affects OS X. Fixes: nodejs#8511
2 tasks
evanlucas
pushed a commit
that referenced
this issue
Nov 3, 2016
The test was sometimes timing out due to a race condition. In OS X, events for `fs.watch()` might only start showing up after a delay. This is a limitation of the operating system. To work around that, there was a timer in the test that delayed the writing of the file by 100ms. However, sometimes that was not enough, and so the event never fired, and the test timed out. Change the timer to an interval so that it fires repeatedly until it is picked up. This change only affects OS X. Fixes: #8511 PR-URL: #9303 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins
pushed a commit
that referenced
this issue
Nov 22, 2016
The test was sometimes timing out due to a race condition. In OS X, events for `fs.watch()` might only start showing up after a delay. This is a limitation of the operating system. To work around that, there was a timer in the test that delayed the writing of the file by 100ms. However, sometimes that was not enough, and so the event never fired, and the test timed out. Change the timer to an interval so that it fires repeatedly until it is picked up. This change only affects OS X. Fixes: #8511 PR-URL: #9303 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins
pushed a commit
that referenced
this issue
Nov 22, 2016
The test was sometimes timing out due to a race condition. In OS X, events for `fs.watch()` might only start showing up after a delay. This is a limitation of the operating system. To work around that, there was a timer in the test that delayed the writing of the file by 100ms. However, sometimes that was not enough, and so the event never fired, and the test timed out. Change the timer to an interval so that it fires repeatedly until it is picked up. This change only affects OS X. Fixes: #8511 PR-URL: #9303 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
BridgeAR
added
the
flaky-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://ci.nodejs.org/job/node-test-commit-osx/5015/nodes=osx1010/console:
@nodejs/testing
The text was updated successfully, but these errors were encountered: