Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-dgram-send-callback-buffer on FreeBSD #7929

Closed
Trott opened this issue Jul 31, 2016 · 0 comments · Fixed by #9199
Closed

Investigate flaky test-dgram-send-callback-buffer on FreeBSD #7929

Trott opened this issue Jul 31, 2016 · 0 comments · Fixed by #9199
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Jul 31, 2016

https://ci.nodejs.org/job/node-test-commit-freebsd/3511/nodes=freebsd10-64/console

not ok 223 parallel/test-dgram-send-callback-buffer
# /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-dgram-send-callback-buffer.js:19
#   throw new Error('Timeout');
#   ^
# 
# Error: Timeout
#     at Timeout._onTimeout (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-dgram-send-callback-buffer.js:19:9)
#     at tryOnTimeout (timers.js:232:11)
#     at Timer.listOnTimeout (timers.js:202:5)
  ---
  duration_ms: 0.409
@Trott Trott added dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests. freebsd Issues and PRs related to the FreeBSD platform. labels Jul 31, 2016
@mscdex mscdex mentioned this issue Oct 15, 2016
Merged
@evanlucas evanlucas mentioned this issue Oct 20, 2016
Merged
3 tasks
evanlucas added a commit to evanlucas/node that referenced this issue Oct 25, 2016
@evanlucas
test: fix flaky test by removing timer
2a654e4 
This fixes one of the tests that has been failing on CI on freebsd for
a bit by removing an unnecessary timer.

PR-URL: nodejs#9199
Fixes: nodejs#7929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
evanlucas added a commit that referenced this issue Nov 2, 2016
@evanlucas
test: fix flaky test by removing timer
efb62aa 
This fixes one of the tests that has been failing on CI on freebsd for
a bit by removing an unnecessary timer.

PR-URL: #9199
Fixes: #7929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this issue Nov 18, 2016
@evanlucas
test: fix flaky test by removing timer
d17ed98 
This fixes one of the tests that has been failing on CI on freebsd for
a bit by removing an unnecessary timer.

PR-URL: #9199
Fixes: #7929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this issue Nov 19, 2016
@evanlucas @MylesBorins
test: fix flaky test by removing timer
0fdfba8 
This fixes one of the tests that has been failing on CI on freebsd for
a bit by removing an unnecessary timer.

PR-URL: #9199
Fixes: #7929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test by removing timer evanlucas/node
1 participant
@Trott