Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Fatal error in ..\..\src\factory.cc, line 1837" in Debug build on Windows #7140

Closed
seishun opened this issue Jun 3, 2016 · 2 comments
Closed

"Fatal error in ..\..\src\factory.cc, line 1837" in Debug build on Windows #7140

seishun opened this issue Jun 3, 2016 · 2 comments
Labels
buffer Issues and PRs related to the buffer subsystem. v8 engine Issues and PRs related to the V8 dependency.

Comments

@seishun
Copy link
Contributor

seishun commented Jun 3, 2016

  • Version: master
  • Platform: Windows 10 64-bit
  • Subsystem: V8?

When running a Debug build of Node.js without any arguments, the following error occurs:

#
# Fatal error in ..\..\src\factory.cc, line 1837
# Check failed: byte_offset + byte_length <= static_cast<size_t>(buffer->byte_length()->Number()).
#

Seems to be a V8 bug. Node.js works just fine in Release.
@addaleax
Copy link
Member

addaleax commented Jun 3, 2016 •
edited
Loading

@seishun Could you try running your build with #6734 included? nvm, that is not supported on Windows, sorry.

@addaleax addaleax added v8 engine Issues and PRs related to the V8 dependency. buffer Issues and PRs related to the buffer subsystem. labels Jun 3, 2016
addaleax added a commit to addaleax/node that referenced this issue Jun 3, 2016
@addaleax
src: fix ArrayBuffer size for zero fill flag
4a021bb 
Use `sizeof()` of the zero fill flag as the byte length of the
`zeroFill` array buffer rather than `1`.

This fixes running debug builds, which have boundary checks for
typed array creations from native code enabled.

Fixes: nodejs#7140
@addaleax addaleax mentioned this issue Jun 3, 2016
Closed
2 tasks
@addaleax
Copy link
Member

addaleax commented Jun 3, 2016

Nice catch, fix is in #7142.

@seishun seishun closed this as completed in ac0665c Jun 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: fix ArrayBuffer size for zero fill flag addaleax/node
2 participants
@addaleax @seishun