Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Teams for the "Who to CC in issues chart" #6655

Closed
Fishrock123 opened this issue May 9, 2016 · 16 comments
Closed

Use Teams for the "Who to CC in issues chart" #6655

Fishrock123 opened this issue May 9, 2016 · 16 comments
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.

Comments

@Fishrock123
Copy link
Contributor

See https://github.com/nodejs/node/blob/master/doc/onboarding-extras.md#who-to-cc-in-issues (Soon to be a table as per https://github.com/Fishrock123/node/blob/doc/improve-onboarding-extras/doc/onboarding-extras.md#who-to-cc-in-issues)

Refs #6548 (comment)

Here's a copy of the (soon to be current) chart directly:

subsystem maintainers
lib/buffer @trevnorris
lib/child_process @cjihrig, @bnoordhuis
lib/cluster @cjihrig, @bnoordhuis
lib/{crypto,tls,https} @nodejs/crypto
lib/domains @misterdjules
lib/{_}http{*} @indutny, @bnoordhuis, @mscdex, @nodejs/http
lib/net @indutny, @bnoordhuis, @nodejs/streams
`lib/{_}stream{s *}`
lib/repl @Fishrock123
lib/timers @Fishrock123, @misterdjules
lib/zlib @indutny, @bnoordhuis
src/async-wrap.* @trevnorris
src/node_crypto.* @nodejs/crypto
test/* @nodejs/testing
tools/eslint, .eslintrc @silverwind, @Trott
upgrading v8 @bnoordhuis, @targos, @ofrobots
upgrading npm @thealphanerd, @Fishrock123

Background:

Would much prefer to make these all team references and begin moving away from specific individuals. Doing so has worked effectively for things like lts, documentation, streams, http, and crypto. For instance, I've created a @nodejs/buffer team as an example.

The downside to mentioning specific individuals is that it creates a disincentive for new collaborators to feel empowered to jump in and help with the reviews and puts too much emphasis and burden on specific individuals.

For some areas, yes.

For other parts of core, I think this is still correct until the knowledge becomes more distilled and distributed as more people learn the codebase, and while that is something we should work towards it doesn't necessarily reflect reality.

@Fishrock123 Fishrock123 added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels May 9, 2016
@jasnell
Copy link
Member

jasnell commented May 9, 2016

The @nodejs/buffer team currently includes @trevnorris, @bnoordhuis, @addaleax and myself.

@misterdjules
Copy link

When making changes to V8, it would be great to notify @nodejs/post-mortem, as the tools they build are highly impacted by changes made to V8.

@santigimeno
Copy link
Member

Would it be worth adding an entry for the debugger?

@Fishrock123
Copy link
Contributor Author

@santigimeno Absolutely!

@bnoordhuis
Copy link
Member

upgrading v8 @bnoordhuis, @targos, @ofrobots

I'd cc @nodejs/v8 for that.

Fishrock123 added a commit to Fishrock123/node that referenced this issue May 9, 2016
Fixes some formatting, improves some formatting, updates minor nits.

Refs: nodejs#6655
PR-URL: nodejs#6548
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@rvagg
Copy link
Member

rvagg commented May 10, 2016

@nodejs/build could be mentioned for anything to do with Makefile, vcbuild.bat, gyp, lots of stuff in tools/ including installers. It's a bit scattered but there's a lot of it.

@mcollina
Copy link
Member

mcollina commented May 10, 2016

fs and path are not listed here.

You can add myself for dgram, but maybe we can form up a wg.

@evanlucas
Copy link
Contributor

util and assert are missing as well

@Fishrock123
Copy link
Contributor Author

fs and path are not listed here.

util and assert are missing as well

Could you suggest people we can list for those? 🐹

@evanlucas
Copy link
Contributor

I know @Trott has messed with assert a bit. You can add me for util. Ben and Colin have spent some time in util as well

@jasnell
Copy link
Member

jasnell commented May 10, 2016

The fs team should most likely include @bnoordhuis, @piscisaureus and @saghul due to the libuv dependency. You can include me because of the Buffer enablement in the API.

@jbergstroem
Copy link
Member

Please add @jbergstroem for updating deps/{http-parser, cares}

@addaleax
Copy link
Member

I can be added for zlib. :-)

@saghul
Copy link
Member

saghul commented May 11, 2016

You can add myself for upgrading deps/libuv.

@Fishrock123
Copy link
Contributor Author

I've made a PR with the notes so far at #6694

@misterdjules
Copy link

@Fishrock123 Thank you!

evanlucas pushed a commit that referenced this issue May 17, 2016
Fixes some formatting, improves some formatting, updates minor nits.

Refs: #6655
PR-URL: #6548
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins pushed a commit that referenced this issue Jun 2, 2016
Fixes some formatting, improves some formatting, updates minor nits.

Refs: #6655
PR-URL: #6548
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins pushed a commit that referenced this issue Jun 2, 2016
Fixes some formatting, improves some formatting, updates minor nits.

Refs: #6655
PR-URL: #6548
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins pushed a commit that referenced this issue Jun 24, 2016
Fixes some formatting, improves some formatting, updates minor nits.

Refs: #6655
PR-URL: #6548
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins pushed a commit that referenced this issue Jun 24, 2016
Fixes some formatting, improves some formatting, updates minor nits.

Refs: #6655
PR-URL: #6548
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Fishrock123 added a commit to Fishrock123/node that referenced this issue Jun 24, 2016
Refs: nodejs#6655

PR-URL: nodejs#6694
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
Fishrock123 added a commit that referenced this issue Jun 27, 2016
Refs: #6655

PR-URL: #6694
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
Fishrock123 added a commit that referenced this issue Jul 5, 2016
Refs: #6655

PR-URL: #6694
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
MylesBorins pushed a commit that referenced this issue Jul 11, 2016
Refs: #6655

PR-URL: #6694
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
MylesBorins pushed a commit that referenced this issue Jul 12, 2016
Refs: #6655

PR-URL: #6694
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
MylesBorins pushed a commit that referenced this issue Jul 12, 2016
Refs: #6655

PR-URL: #6694
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
MylesBorins pushed a commit that referenced this issue Jul 12, 2016
Refs: #6655

PR-URL: #6694
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
MylesBorins pushed a commit that referenced this issue Jul 14, 2016
Refs: #6655

PR-URL: #6694
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
MylesBorins pushed a commit that referenced this issue Jul 14, 2016
Refs: #6655

PR-URL: #6694
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests