Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uncaughtException documentation should mention that it not a reliable «restart on crash» method #6223

Closed
ChALkeR opened this issue Apr 15, 2016 · 0 comments
Closed

uncaughtException documentation should mention that it not a reliable «restart on crash» method #6223

ChALkeR opened this issue Apr 15, 2016 · 0 comments
Labels
doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.

Comments

@ChALkeR
Copy link
Member

ChALkeR commented Apr 15, 2016 •
edited
Loading

I had a discussion with a user today who apparently thought that uncaughtException event could be used as a reliable way to restart the application on a crash (after the cleanup and termination). Or that's how I understood what he told me.

The documentation for uncaughtException already has a long and expressive warning noting that the process must not be continued after receiving that exception (ref).

Perhaps it should also explicitly note that the application could crash in ways that do not trigger this event, and that if one wants to restart the process in a guaranteed way — an external watcher should be used.
@ChALkeR ChALkeR added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Apr 15, 2016
@evanlucas evanlucas added the good first issue Issues that are suitable for first-time contributors. label Apr 25, 2016
@lance lance mentioned this issue Apr 25, 2016
Closed
2 tasks
@Fishrock123 Fishrock123 removed the good first issue Issues that are suitable for first-time contributors. label May 5, 2016
@lance lance closed this as completed in 2fe277a Jul 15, 2016
evanlucas pushed a commit that referenced this issue Jul 19, 2016
@lance @evanlucas
doc: Warn against uncaughtException dependency.
c726ffb 
State in the documentation that `uncaughtException` is not a reliable
way to restart a crashed application, and clarify that an application
may crash in ways that do not trigger this event.

Use a documented synchronous function in example code.

Fixes: #6223

Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #6378
evanlucas pushed a commit that referenced this issue Jul 20, 2016
@lance @evanlucas
doc: Warn against uncaughtException dependency.
9c274e3 
State in the documentation that `uncaughtException` is not a reliable
way to restart a crashed application, and clarify that an application
may crash in ways that do not trigger this event.

Use a documented synchronous function in example code.

Fixes: #6223

Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #6378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ChALkeR @evanlucas @Fishrock123