Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version number in deps/openssl/openssl/Makefile on all release lines #5615

Closed
rvagg opened this issue Mar 9, 2016 · 4 comments
Closed
Labels
openssl Issues and PRs related to the OpenSSL dependency.

Comments

@rvagg
Copy link
Member

rvagg commented Mar 9, 2016

Currently:

$ grep ^VERSION */deps/openssl/openssl/Makefile
master/deps/openssl/openssl/Makefile:VERSION=1.0.2f
node_0.10/deps/openssl/openssl/Makefile:VERSION=1.0.1r
node_0.12/deps/openssl/openssl/Makefile:VERSION=1.0.1r
node_4.x/deps/openssl/openssl/Makefile:VERSION=1.0.2f
node_5.x/deps/openssl/openssl/Makefile:VERSION=1.0.2f

We should be on 1.0.2g and 1.0.1s, I believe this is just a problem in the Makefile but it's what I'm currently using to figure out the version for https://nodejs.org/dist/index.tab and https://nodejs.org/dist/index.json and it's wrong for our recent releases.

  1. Can we get this fixed please and if it's not OpenSSL's fault, could we make sure it's part of the upgrade procedure to get it right?
  2. Is there s better way of getting the version, including historically? Maybe deps/openssl/openssl/include/openssl/opensslv.h is the authoritative location that I should be using?

@nodejs/crypto

@mscdex mscdex added the openssl Issues and PRs related to the OpenSSL dependency. label Mar 9, 2016
@shigeki
Copy link
Contributor

shigeki commented Mar 9, 2016

  1. Makefile and Makefile.bak are included in tar ball distributed at https://www.openssl.org/source/ but not in git repo. Probably they are not updated because the sources are from git rep.
    Is that right, @bnoordhuis ? But we need not to worry that because these two files are not used in Node.
  2. Yes, 'deps/openssl/openssl/include/openssl/opensslv.h' is right.

I checked if there are other differences and nothing was found except small whitespace changes and Makefile. But I found another issue that openssl configs were missed to updated. For I have to go out now, I will fix it later.

@bnoordhuis
Copy link
Member

@shigeki is right, they're openssl release artifacts. opensslv.h is the best place to get the version number from.

@bnoordhuis
Copy link
Member

FWIW, here are the files we're missing:

$ for FILE in $(git ls-tree -r --name-only HEAD); do [ -f ../v1.x/deps/openssl/openssl/$FILE ] || echo $FILE; done
.gitignore
.travis-create-release.sh
.travis.yml
TABLE
crypto/des/t/test

TABLE is a configuration template that we don't use. crypto/des/t/test is a short perl script.

@rvagg
Copy link
Member Author

rvagg commented Mar 9, 2016

moving to #5619

@rvagg rvagg closed this as completed Mar 9, 2016
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Mar 21, 2016
Refs: nodejs#5615
PR-URL: nodejs#5619
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rod Vagg <rod@vagg.org>
Fishrock123 pushed a commit that referenced this issue Mar 22, 2016
Refs: #5615
PR-URL: #5619
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this issue Mar 30, 2016
Refs: #5615
PR-URL: #5619
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this issue Mar 30, 2016
Refs: #5615
PR-URL: #5619
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Development

No branches or pull requests

4 participants