Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominating @ljharb to be a Collaborator #55918

Closed
mcollina opened this issue Nov 19, 2024 · 14 comments · Fixed by #56132
Closed

Nominating @ljharb to be a Collaborator #55918

mcollina opened this issue Nov 19, 2024 · 14 comments · Fixed by #56132
Labels
meta Issues and PRs related to the general management of the project.

Comments

@mcollina
Copy link
Member

I nominate @ljharb as a collaborator. He has been helping review code in Node.js for a long time and has expressed interest in becoming a releaser in the future. He is also an OpenJS Board member (https://openjsf.org/governance).

Commits authored on nodejs/node: github.com/nodejs/node/commits?author=ljharb
Pull requests opened: github.com/search?q=author:ljharb+org:nodejs&type=pullrequests
Issues opened: github.com/search?q=author:ljharb+org:nodejs&type=issues
Comments on pull requests and issues throughout the Node.js organization: https://github.com/search?q=commenter%3Aljharb+org%3Anodejs&type=pullrequests

@avivkeller avivkeller added the meta Issues and PRs related to the general management of the project. label Nov 19, 2024
@juanarbol
Copy link
Member

+1

@aduh95
Copy link
Contributor

aduh95 commented Nov 26, 2024

Looks like we forgot to mention @nodejs/collaborators as our governance document stipulates

node/GOVERNANCE.md

Lines 169 to 170 in bc39796

Mention @nodejs/collaborators in the issue to notify other collaborators about
the nomination.

@RafaelGSS
Copy link
Member

+1

@JakobJingleheimer
Copy link
Member

JakobJingleheimer commented Nov 26, 2024

+1 I've had exclusively positive experiences in the past years.

@UlisesGascon
Copy link
Member

+1 I think that is a great addition! I've participated in WGs and spaces and I learned a lot from him.

@himself65
Copy link
Member

+1

@Qard
Copy link
Member

Qard commented Nov 28, 2024

+1 from me. @ljharb has been a generally positive influence in the interactions we have had. 🙂

@ruyadorno
Copy link
Member

+1

@VoltrexKeyva
Copy link
Member

VoltrexKeyva commented Nov 28, 2024

+1, he would be an awesome addition.

@jasnell
Copy link
Member

jasnell commented Nov 28, 2024

+1

@Ethan-Arrowood
Copy link
Contributor

+1 - working with Jordan is great 😄

@Trott
Copy link
Member

Trott commented Nov 29, 2024

If I'm not mistaken, this has been open for more than a week with no objections so the nomination is officially successful. I believe the next step is for a TSC member to schedule an onboarding for Jordan. 🚀

@anonrig
Copy link
Member

anonrig commented Dec 4, 2024

I'll reach out to @ljharb and schedule the onboarding session.

ljharb added a commit to ljharb/node that referenced this issue Dec 4, 2024
@ljharb
Copy link
Member

ljharb commented Dec 4, 2024

#56132

ljharb added a commit to ljharb/node that referenced this issue Dec 4, 2024
ljharb added a commit to ljharb/node that referenced this issue Dec 4, 2024
@ljharb ljharb closed this as completed in c4aa34a Dec 4, 2024
aduh95 pushed a commit to aduh95/node that referenced this issue Dec 4, 2024
Fixes: nodejs#55918
PR-URL: nodejs#56132
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
targos pushed a commit that referenced this issue Dec 6, 2024
Fixes: #55918
PR-URL: #56132
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
aduh95 pushed a commit that referenced this issue Dec 13, 2024
Fixes: #55918
PR-URL: #56132
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
aduh95 pushed a commit that referenced this issue Dec 13, 2024
Fixes: #55918
PR-URL: #56132
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
aduh95 pushed a commit that referenced this issue Dec 13, 2024
Fixes: #55918
PR-URL: #56132
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
aduh95 pushed a commit that referenced this issue Dec 18, 2024
Fixes: #55918
PR-URL: #56132
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
ruyadorno pushed a commit that referenced this issue Jan 5, 2025
Fixes: #55918
PR-URL: #56132
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.