Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test test/parallel/test-runner-run.mjs fails when run from a TTY with color support #54551

Closed
cjihrig opened this issue Aug 25, 2024 · 0 comments · Fixed by #54552
Closed

Test test/parallel/test-runner-run.mjs fails when run from a TTY with color support #54551

cjihrig opened this issue Aug 25, 2024 · 0 comments · Fixed by #54552
Labels
good first issue Issues that are suitable for first-time contributors. test Issues and PRs related to the tests.

Comments

@cjihrig
Copy link
Contributor

cjihrig commented Aug 25, 2024

Version

main

Platform

all

Subsystem

test

What steps will reproduce the bug?

node test/parallel/test-runner-run.mjs

How often does it reproduce? Is there a required condition?

100% of the time for me

What is the expected behavior? Why is that the expected behavior?

The test passes.

What do you see instead?

✖ should be piped with dot (163.96875ms)
  AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
  + actual - expected
  
    [
  +   '\x1B[32m.\x1Bc',
  -   '.',
      '\n'
    ]

Additional information

The test does not account for the possibility of output with color support.
@cjihrig cjihrig added good first issue Issues that are suitable for first-time contributors. test Issues and PRs related to the tests. labels Aug 25, 2024
puskin94 added a commit to puskin94/node that referenced this issue Aug 25, 2024
@puskin94
test: make test-runner-run.mjs ignore colors
c10609a 
Fixes: nodejs#54551
puskin94 added a commit to puskin94/node that referenced this issue Aug 25, 2024
@puskin94
test: making test-runner-run.mjs ignore colors
d1ce27f 
Fixes: nodejs#54551
@puskin94 puskin94 mentioned this issue Aug 25, 2024
Merged
puskin94 added a commit to puskin94/node that referenced this issue Aug 25, 2024
@puskin94
test: ignore colors in test-runner-run
efa87fc 
Fixes: nodejs#54551
puskin94 added a commit to puskin94/node that referenced this issue Aug 25, 2024
@puskin94
test: ignore colors in test-runner-run
6dabfd0 
Fixes: nodejs#54551
puskin94 added a commit to puskin94/node that referenced this issue Aug 25, 2024
@puskin94
test: ignore colors in test-runner-run
1eee01c 
Fixes: nodejs#54551
puskin94 added a commit to puskin94/node that referenced this issue Aug 26, 2024
@puskin94
test: ignore colors in test-runner-run
fbff99f 
Fixes: nodejs#54551
puskin94 added a commit to puskin94/node that referenced this issue Aug 27, 2024
@puskin94
test: ignore colors in test-runner-run when not a TTY
79e477d 
Fixes: nodejs#54551
puskin94 added a commit to puskin94/node that referenced this issue Aug 27, 2024
@puskin94
test: strip color chars in test-runner-run
3078f79 
Fixes: nodejs#54551
puskin94 added a commit to puskin94/node that referenced this issue Aug 27, 2024
@puskin94
test: strip color chars in test-runner-run
7d9ab97 
Fixes: nodejs#54551
puskin94 added a commit to puskin94/node that referenced this issue Aug 27, 2024
@puskin94
test: strip color chars in test-runner-run
09dd583 
Fixes: nodejs#54551
puskin94 added a commit to puskin94/node that referenced this issue Sep 2, 2024
@puskin94
test: strip color chars in test-runner-run
5a72580 
Fixes: nodejs#54551
puskin94 added a commit to puskin94/node that referenced this issue Sep 2, 2024
@puskin94
test: strip color chars in test-runner-run
527ea96 
Fixes: nodejs#54551
puskin94 added a commit to puskin94/node that referenced this issue Sep 2, 2024
@puskin94
test: strip color chars in test-runner-run
ba16650 
Fixes: nodejs#54551
puskin94 added a commit to puskin94/node that referenced this issue Sep 10, 2024
@puskin94
test: strip color chars in test-runner-run
f4e1232 
Fixes: nodejs#54551
puskin94 added a commit to puskin94/node that referenced this issue Sep 10, 2024
@puskin94
test: strip color chars in test-runner-run
21b839f 
Fixes: nodejs#54551
puskin94 added a commit to puskin94/node that referenced this issue Sep 10, 2024
@puskin94
test: strip color chars in test-runner-run
120d49b 
Fixes: nodejs#54551
RafaelGSS pushed a commit that referenced this issue Sep 16, 2024
@puskin94 @RafaelGSS
test: strip color chars in test-runner-run
0647853 
Fixes: #54551
PR-URL: #54552
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this issue Sep 16, 2024
@puskin94 @RafaelGSS
test: strip color chars in test-runner-run
430b7a0 
Fixes: #54551
PR-URL: #54552
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this issue Sep 17, 2024
@puskin94 @RafaelGSS
test: strip color chars in test-runner-run
ee385d6 
Fixes: #54551
PR-URL: #54552
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this issue Sep 22, 2024
@puskin94 @targos
test: strip color chars in test-runner-run
1999e26 
Fixes: #54551
PR-URL: #54552
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this issue Sep 26, 2024
@puskin94 @targos
test: strip color chars in test-runner-run
ba73697 
Fixes: #54551
PR-URL: #54552
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this issue Oct 2, 2024
@puskin94 @targos
test: strip color chars in test-runner-run
ca0e30a 
Fixes: #54551
PR-URL: #54552
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this issue Oct 2, 2024
@puskin94 @targos
test: strip color chars in test-runner-run
d2ec961 
Fixes: #54551
PR-URL: #54552
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: making test-runner-run.mjs ignore colors puskin94/node
1 participant
@cjihrig