Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-http-outgoing-end-cork ignores platformTimeout and fail on slow archs #54499

Closed
kapouer opened this issue Aug 22, 2024 · 2 comments
Closed
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@kapouer
Copy link
Contributor

kapouer commented Aug 22, 2024

Test

test-http-outgoing-end-cork

Platform

No response

Console output

not ok 1287 parallel/test-http-outgoing-end-cork
---
duration_ms: 6970.84500
severity: fail
exitcode: 1
stack: |-
	Sending req no 1
	node:assert:173
		throw err;
		^
	
	AssertionError [ERR_ASSERTION]: () => {
			reject(new Error('Request timed out'));
		} at /tmp/autopkgtest-lxc.i258yc3s/downtmp/build.JNN/src/test/parallel/test-http-outgoing-end-cork.js:53
			at Timeout.mustNotCall [as _onTimeout] (/tmp/autopkgtest-lxc.i258yc3s/downtmp/build.JNN/src/test/common/index.js:547:12)
			at listOnTimeout (node:internal/timers:581:17)
			at process.processTimers (node:internal/timers:519:7) {
		generatedMessage: false,
		code: 'ERR_ASSERTION',
		actual: undefined,
		expected: undefined,
		operator: 'fail'
	}
	
	Node.js v20.16.0

Build links

Additional information

This build is for node 20.7.0 on riscv64 arch.
I know it is not supported, but it would be nice anyway to have timeouts proportional to platformTimeout for all tests.

In that test,
const REQ_TIMEOUT = 500; // Set max ms of request time before abort
// Set total allowed test timeout to avoid infinite loop
// that will hang test suite
const TOTAL_TEST_TIMEOUT = 1000;

@kapouer kapouer added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Aug 22, 2024
jakecastelli added a commit that referenced this issue Sep 12, 2024
PR-URL: #54591
Refs: #54499
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
jakecastelli added a commit that referenced this issue Sep 12, 2024
PR-URL: #54591
Refs: #54499
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@jakecastelli
Copy link
Member

This should be fixed in #54591, please let me know if there's any issue 🙏

aduh95 pushed a commit that referenced this issue Sep 12, 2024
PR-URL: #54591
Refs: #54499
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this issue Sep 12, 2024
PR-URL: #54591
Refs: #54499
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this issue Sep 13, 2024
PR-URL: #54591
Refs: #54499
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this issue Sep 13, 2024
PR-URL: #54591
Refs: #54499
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this issue Sep 13, 2024
PR-URL: #54591
Refs: #54499
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this issue Sep 13, 2024
PR-URL: #54591
Refs: #54499
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this issue Sep 22, 2024
PR-URL: #54591
Refs: #54499
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this issue Sep 26, 2024
PR-URL: #54591
Refs: #54499
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@lpinca
Copy link
Member

lpinca commented Sep 28, 2024

I'm closing this as per #54499 (comment).

@lpinca lpinca closed this as completed Sep 28, 2024
targos pushed a commit that referenced this issue Oct 2, 2024
PR-URL: #54591
Refs: #54499
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this issue Oct 2, 2024
PR-URL: #54591
Refs: #54499
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
louwers pushed a commit to louwers/node that referenced this issue Nov 2, 2024
PR-URL: nodejs#54591
Refs: nodejs#54499
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
louwers pushed a commit to louwers/node that referenced this issue Nov 2, 2024
PR-URL: nodejs#54591
Refs: nodejs#54499
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
tpoisseau pushed a commit to tpoisseau/node that referenced this issue Nov 21, 2024
PR-URL: nodejs#54591
Refs: nodejs#54499
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
tpoisseau pushed a commit to tpoisseau/node that referenced this issue Nov 21, 2024
PR-URL: nodejs#54591
Refs: nodejs#54499
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Development

No branches or pull requests

3 participants