-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-http-outgoing-end-cork ignores platformTimeout and fail on slow archs #54499
Labels
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
Comments
kapouer
added
the
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
label
Aug 22, 2024
This should be fixed in #54591, please let me know if there's any issue 🙏 |
I'm closing this as per #54499 (comment). |
louwers
pushed a commit
to louwers/node
that referenced
this issue
Nov 2, 2024
PR-URL: nodejs#54591 Refs: nodejs#54499 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
louwers
pushed a commit
to louwers/node
that referenced
this issue
Nov 2, 2024
PR-URL: nodejs#54591 Refs: nodejs#54499 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this issue
Nov 21, 2024
PR-URL: nodejs#54591 Refs: nodejs#54499 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this issue
Nov 21, 2024
PR-URL: nodejs#54591 Refs: nodejs#54499 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Test
test-http-outgoing-end-cork
Platform
No response
Console output
Build links
Additional information
This build is for node 20.7.0 on riscv64 arch.
I know it is not supported, but it would be nice anyway to have timeouts proportional to platformTimeout for all tests.
In that test,
const REQ_TIMEOUT = 500; // Set max ms of request time before abort
// Set total allowed test timeout to avoid infinite loop
// that will hang test suite
const TOTAL_TEST_TIMEOUT = 1000;
The text was updated successfully, but these errors were encountered: