Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel/test-esm-loader-hooks-inspect-wait child process crashes #54346

Open
richardlau opened this issue Aug 12, 2024 · 5 comments
Open

parallel/test-esm-loader-hooks-inspect-wait child process crashes #54346

richardlau opened this issue Aug 12, 2024 · 5 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. linux Issues and PRs related to the Linux platform. s390 Issues and PRs related to the s390 architecture.

Comments

@richardlau
Copy link
Member

richardlau commented Aug 12, 2024

Test

parallel/test-esm-loader-hooks-inspect-wait

Platform

Linux s390x, Linux x64

Console output

04:52:51 not ok 1100 parallel/test-esm-loader-hooks-inspect-wait
04:52:51   ---
04:52:51   duration_ms: 710.56400
04:52:51   severity: fail
04:52:51   exitcode: 1
04:52:51   stack: |-
04:52:51     [test] Connecting to a child Node process
04:52:51     [test] Testing /json/list
04:52:51     [err] Debugger listening on ws://127.0.0.1:36913/4edb9b89-b057-4298-8732-067307515397
04:52:51     [err] For help, see: https://nodejs.org/en/docs/inspector
04:52:51     [err] 
04:52:51     [err] Debugger attached.
04:52:51     [err] 
04:52:51     [err] Waiting for the debugger to disconnect...
04:52:51     [err] 
04:52:51     [err] child process crashed, signal SIGSEGV
04:52:51     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
04:52:51     
04:52:51     null !== 0
04:52:51     
04:52:51         at runTest (/home/iojs/build/workspace/node-test-commit-linux/test/parallel/test-esm-loader-hooks-inspect-wait.js:30:10)
04:52:51         at process.processTicksAndRejections (node:internal/process/task_queues:105:5) {
04:52:51       generatedMessage: true,
04:52:51       code: 'ERR_ASSERTION',
04:52:51       actual: null,
04:52:51       expected: 0,
04:52:51       operator: 'strictEqual'
04:52:51     }
04:52:51     1
04:52:51   ...

Build links

Additional information

According to https://github.com/nodejs/reliability/issues?q=is%3Aissue+is%3Aopen+%22test-esm-loader-hooks-inspect-wait%22 this started showing up from the 9 August reliability report.

@richardlau richardlau added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Aug 12, 2024
@github-actions github-actions bot added s390 Issues and PRs related to the s390 architecture. linux Issues and PRs related to the Linux platform. labels Aug 12, 2024
@richardlau richardlau changed the title parallel/test-esm-loader-hooks-inspect-wait crashes parallel/test-esm-loader-hooks-inspect-wait child process crashes Aug 12, 2024
@anonrig
Copy link
Member

anonrig commented Sep 6, 2024

This is flaky on Ubuntu 22.04 as well: https://ci.nodejs.org/job/node-test-commit-linux-containered/45976/

@aduh95
Copy link
Contributor

aduh95 commented Sep 6, 2024

I can reproduce locally (on macOS), it's very rare (2 failures in 9999 runs). SIGSEGV means we're doing some kind of unsafe memory access, which sounds like a real bug 🤔

@avivkeller
Copy link
Member

avivkeller commented Sep 12, 2024

FWIW I got ~11 failures in 1000 runs on Linux. (after @lpinca's PR)

However, I'm unable to reproduce in v22.8.0.

@richardlau
Copy link
Member Author

https://github.com/nodejs/reliability/blob/main/reports/2025-01-27.md shows this still happening on FreeBSD and SmartOS while #56792 (comment) is an instance of this failure on AIX.

#54802 marked this test as flaky on Linux -- I'll open a PR to extend the flaky status to the other platforms.

nodejs-github-bot pushed a commit that referenced this issue Jan 29, 2025
`test-esm-loader-hooks-inspect-wait` is occasionally crashing on more
platforms than Linux. Mark the test as flaky on those platforms as well.

PR-URL: #56803
Refs: #54346
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Feb 2, 2025
`test-esm-loader-hooks-inspect-wait` is occasionally crashing on more
platforms than Linux. Mark the test as flaky on those platforms as well.

PR-URL: #56803
Refs: #54346
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. linux Issues and PRs related to the Linux platform. s390 Issues and PRs related to the s390 architecture.
Projects
None yet
Development

No branches or pull requests

5 participants