Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/mock_loader module exposed without node: prefix #54071

Closed
Renegade334 opened this issue Jul 27, 2024 · 1 comment · Fixed by #54106
Closed

test/mock_loader module exposed without node: prefix #54071

Renegade334 opened this issue Jul 27, 2024 · 1 comment · Fixed by #54106

Comments

@Renegade334
Copy link
Contributor

Renegade334 commented Jul 27, 2024 •
edited
Loading

The builtin module test/mock_loader was added in v22.3.0. However, it wasn't added to schemelessBlockList, meaning it's currently importable as "test/mock_loader", and appears in module.builtinModules.

Could be as simple as adding the new module to the list, although I wonder if realm.js should implement some kind of matching behaviour so that if a module foo is in schemelessBlockList, then any foo/bar submodules are automatically excluded as well.
@Renegade334 Renegade334 changed the title tests/mock_loader module exposed without node: prefix test/mock_loader module exposed without node: prefix Jul 27, 2024
@cjihrig
Copy link
Contributor

cjihrig commented Jul 28, 2024

One thing to note is that the loader is not intended to be public at all. We need register() to support internals (it didn't the last time I tested it).

@aduh95 aduh95 mentioned this issue Jul 29, 2024
Merged
aduh95 added a commit that referenced this issue Aug 13, 2024
@aduh95
test_runner: do not expose internal loader
d0f5943 
PR-URL: #54106
Fixes: #54071
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this issue Aug 14, 2024
@aduh95 @targos
test_runner: do not expose internal loader
e8b4768 
PR-URL: #54106
Fixes: #54071
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this issue Aug 14, 2024
@aduh95 @targos
test_runner: do not expose internal loader
fe793a6 
PR-URL: #54106
Fixes: #54071
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@nicolo-ribaudo nicolo-ribaudo mentioned this issue Aug 21, 2024
Merged
@vicb vicb mentioned this issue Sep 3, 2024
Merged
targos pushed a commit that referenced this issue Sep 21, 2024
@aduh95 @targos
test_runner: do not expose internal loader
9fcad9e 
PR-URL: #54106
Fixes: #54071
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this issue Sep 26, 2024
@aduh95 @targos
test_runner: do not expose internal loader
7d791ec 
PR-URL: #54106
Fixes: #54071
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this issue Oct 2, 2024
@aduh95 @targos
test_runner: do not expose internal loader
27da75a 
PR-URL: #54106
Fixes: #54071
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test_runner: do not expose internal loader aduh95/node
2 participants
@cjihrig @Renegade334