Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parallel/test-blob-file-backed is flaky #51860

Closed
joyeecheung opened this issue Feb 23, 2024 · 1 comment · Fixed by #53920
Closed

parallel/test-blob-file-backed is flaky #51860

joyeecheung opened this issue Feb 23, 2024 · 1 comment · Fixed by #53920
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Comments

@joyeecheung
Copy link
Member

Reason parallel/test-blob-file-backed
Type JS_TEST_FAILURE
Failed PR 4 (https://github.com/nodejs/node/pull/51783/, https://github.com/nodejs/node/pull/51687/, https://github.com/nodejs/node/pull/51810/, https://github.com/nodejs/node/pull/51815/)
Appeared test-ibm-ubuntu2204_sharedlibs_container-x64-5, test-rackspace-win2019_vs2019-x64-1, test-ibm-rhel8-s390x-2, test-digitalocean-ubuntu2204_sharedlibs_container-x64-9
First CI https://ci.nodejs.org/job/node-test-pull-request/57228/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57286/
Example 
not ok 352 parallel/test-blob-file-backed
  ---
  duration_ms: 202.59200
  severity: fail
  exitcode: 1
  stack: |-
    
    node:internal/blob:291
              const error = lazyDOMException('The blob could not be read', 'NotReadableError');
                            ^
    DOMException [NotReadableError]: The blob could not be read
        at BlobReader.<anonymous> (node:internal/blob:291:25)
    
    Node.js v22.0.0-pre
  ...

From nodejs/reliability#791
@joyeecheung joyeecheung added test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Feb 23, 2024
@mhdawson
Copy link
Member

Again - https://ci.nodejs.org/job/node-test-commit-linux/nodes=fedora-latest-x64/56789/

lpinca added a commit to lpinca/node that referenced this issue Jul 18, 2024
@lpinca
test: deflake test-blob-file-backed
3110d91 
Avoid race conditions by using a different file for each subtest.

Fixes: nodejs#51860
@lpinca lpinca mentioned this issue Jul 18, 2024
Merged
nodejs-github-bot pushed a commit that referenced this issue Jul 20, 2024
@lpinca
test: deflake test-blob-file-backed
50d09bc 
Avoid race conditions by using a different file for each subtest.

Fixes: #51860
PR-URL: #53920
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this issue Jul 28, 2024
@lpinca @targos
test: deflake test-blob-file-backed
c247582 
Avoid race conditions by using a different file for each subtest.

Fixes: #51860
PR-URL: #53920
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
marco-ippolito pushed a commit that referenced this issue Aug 19, 2024
@lpinca @marco-ippolito
test: deflake test-blob-file-backed
b18eee1 
Avoid race conditions by using a different file for each subtest.

Fixes: #51860
PR-URL: #53920
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
marco-ippolito pushed a commit that referenced this issue Aug 19, 2024
@lpinca @marco-ippolito
test: deflake test-blob-file-backed
aa96171 
Avoid race conditions by using a different file for each subtest.

Fixes: #51860
PR-URL: #53920
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
marco-ippolito pushed a commit that referenced this issue Aug 19, 2024
@lpinca @marco-ippolito
test: deflake test-blob-file-backed
be94e47 
Avoid race conditions by using a different file for each subtest.

Fixes: #51860
PR-URL: #53920
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: deflake test-blob-file-backed lpinca/node
2 participants
@joyeecheung @mhdawson