Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The kDisableNodeOptionsEnv option can be work around by using NODE_REPL_EXTERNAL_MODULE env #51227

Closed
zcbenz opened this issue Dec 20, 2023 · 3 comments · Fixed by #52905
Closed

The kDisableNodeOptionsEnv option can be work around by using NODE_REPL_EXTERNAL_MODULE env #51227

zcbenz opened this issue Dec 20, 2023 · 3 comments · Fixed by #52905
Labels
security Issues and PRs related to security.

Comments

@zcbenz
Copy link
Contributor

zcbenz commented Dec 20, 2023

Node has an kDisableNodeOptionsEnv embedder flag that disables NODE_OPTIONS env to avoid injecting external code into apps, however it can be bypassed by using the NODE_REPL_EXTERNAL_MODULE env as reported by electron/electron#40770.

I understand kDisableNodeOptionsEnv only means to disable NODE_OPTIONS env, but if we don't also disable NODE_REPL_EXTERNAL_MODULE the protection would become meaningless.

I think we have 2 options to fix this:

  1. Disable NODE_REPL_EXTERNAL_MODULE env when kDisableNodeOptionsEnv is used.
  2. Deprecate kDisableNodeOptionsEnv and add a new flag that disables all possible ways to inject code.

I wonder which one would be preferred by Node team. /cc @addaleax @joyeecheung @bnoordhuis
@avivkeller
Copy link
Member

@nodejs/security-wg

@avivkeller avivkeller added the dotenv Issues and PRs related to .env file parsing label Apr 26, 2024
@avivkeller
Copy link
Member

avivkeller commented Apr 26, 2024 •
edited
Loading

Dotenv isn't the correct label (no dotenv file), buts AFAIK the closest to env variables

@avivkeller avivkeller added the security Issues and PRs related to security. label Apr 26, 2024
@RafaelGSS RafaelGSS removed the dotenv Issues and PRs related to .env file parsing label Apr 29, 2024
@RafaelGSS
Copy link
Member

RafaelGSS commented Apr 29, 2024 •
edited
Loading

@zcbenz While the first option is trivial I assume it will be a breaking change for all users that rely on the current behavior. I believe a new flag should be a safer approach. Honestly, I'm fine with both options.

cc: @nodejs/tsc

@RafaelGSS RafaelGSS mentioned this issue May 8, 2024
Merged
nodejs-github-bot pushed a commit that referenced this issue May 23, 2024
@RafaelGSS
src: fix external module env and kDisableNodeOptionsEnv
b9ad94b 
PR-URL: #52905
Fixes: #51227
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos pushed a commit that referenced this issue Jun 1, 2024
@RafaelGSS @targos
src: fix external module env and kDisableNodeOptionsEnv
7aa9519 
PR-URL: #52905
Fixes: #51227
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
EliphazBouye pushed a commit to EliphazBouye/node that referenced this issue Jun 20, 2024
@RafaelGSS @EliphazBouye
src: fix external module env and kDisableNodeOptionsEnv
8691502 
PR-URL: nodejs#52905
Fixes: nodejs#51227
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this issue Jun 22, 2024
@RafaelGSS @bmeck
src: fix external module env and kDisableNodeOptionsEnv
ea6d0ec 
PR-URL: nodejs#52905
Fixes: nodejs#51227
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
marco-ippolito pushed a commit that referenced this issue Jul 19, 2024
@RafaelGSS @marco-ippolito
src: fix external module env and kDisableNodeOptionsEnv
a5b2928 
PR-URL: #52905
Fixes: #51227
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
marco-ippolito pushed a commit that referenced this issue Jul 19, 2024
@RafaelGSS @marco-ippolito
src: fix external module env and kDisableNodeOptionsEnv
3b79e9c 
PR-URL: #52905
Fixes: #51227
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
security Issues and PRs related to security.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: sync NODE_REPL_EXTERNAL_MODULE and kDisableNodeOptionsEnv RafaelGSS/node
3 participants
@zcbenz @RafaelGSS @avivkeller