Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update-icu.sh is broken #50498

Closed
marco-ippolito opened this issue Nov 1, 2023 · 9 comments · May be fixed by #50507
Closed

tools: update-icu.sh is broken #50498

marco-ippolito opened this issue Nov 1, 2023 · 9 comments · May be fixed by #50507
Labels
good first issue Issues that are suitable for first-time contributors. tools Issues and PRs related to the tools directory.

Comments

@marco-ippolito
Copy link
Member

Refs: #50495
Somehow the script is not getting the new version correctly and updating maintaining-dependencies.md
@marco-ippolito marco-ippolito added good first issue Issues that are suitable for first-time contributors. tools Issues and PRs related to the tools directory. labels Nov 1, 2023
@targos
Copy link
Member

targos commented Nov 1, 2023

There's no .md5 file in the assets for version 74.1
https://github.com/unicode-org/icu/releases/tag/release-74-1
https://github.com/unicode-org/icu/releases/tag/release-73-2

@targos
Copy link
Member

targos commented Nov 1, 2023

Should we use the .asc file instead?

@targos
Copy link
Member

targos commented Nov 1, 2023

@srl295 Is it expected that we don't find the md5 files anymore?

@marco-ippolito
Copy link
Member Author

Should we use the .asc file instead?

I think this is the fastest solution

@srl295
Copy link
Member

srl295 commented Nov 1, 2023

May be an oversight.

@markusicu @pedberg-icu ?

@islandryu islandryu mentioned this issue Nov 1, 2023
Open
islandryu added a commit to islandryu/node that referenced this issue Nov 1, 2023
@islandryu
tools: verify with gpg if md5 is not present in update-icu
996127a 
ICU releases may not include md5 files to verify code
Added a branch to verify from .asc file using gpg in such cases

Fixes: nodejs#50498
@richardlau
Copy link
Member

I've opened an upstream issue: https://unicode-org.atlassian.net/jira/software/c/projects/ICU/issues/ICU-22567

@markusicu
Copy link

Fixed. @mihnita

  • Created and uploaded icu4c-74_1-src.md5
  • Renamed icu4c-74_1_binary.md5 to icu4c-74_1-binary.md5, to match 73_2
  • Removed icu4j-74.1.md5 from 73_2

@srl295
Copy link
Member

srl295 commented Nov 1, 2023

Is the build script able to use release candidate tarballs?

islandryu added a commit to islandryu/node that referenced this issue Nov 5, 2023
@islandryu
tools: verify with gpg if md5 is not present in update-icu
f2bf139 
ICU releases may not include md5 files to verify code
Added a branch to verify from .asc file using gpg in such cases

Fixes: nodejs#50498
islandryu added a commit to islandryu/node that referenced this issue Nov 7, 2023
@islandryu
tools: verify with gpg if md5 is not present in update-icu
df5fad8 
ICU releases may not include md5 files to verify code
Added a branch to verify from .asc file using gpg in such cases

Fixes: nodejs#50498
@targos targos mentioned this issue Jan 8, 2024
Closed
islandryu added a commit to islandryu/node that referenced this issue May 20, 2024
@islandryu
tools: verify with gpg if md5 is not present in update-icu
a95ea15 
ICU releases may not include md5 files to verify code
Added a branch to verify from .asc file using gpg in such cases

Fixes: nodejs#50498
@marco-ippolito
Copy link
Member Author

it seems to be working fine now #52573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: verify with gpg if md5 is not present in update-icu islandryu/node
5 participants
@srl295 @targos @richardlau @markusicu @marco-ippolito