Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undici_version.h and acorn_version.h displaying wrong update script path #50159

Closed
MrJithil opened this issue Oct 12, 2023 · 2 comments · Fixed by #50165 or #50175
Closed

undici_version.h and acorn_version.h displaying wrong update script path #50159

MrJithil opened this issue Oct 12, 2023 · 2 comments · Fixed by #50165 or #50175
Labels
good first issue Issues that are suitable for first-time contributors.

Comments

@MrJithil
Copy link
Member

MrJithil commented Oct 12, 2023 •
edited
Loading

Comments in below files are pointing to wrong path of their corresponding dep update scripts.

Below changes needed.

  • undici_version.h - // Refer to tools/update-undici.sh must be // Refer to tools/dep_updaters/update-undici.sh
  • update-acorn.sh - // Refer to tools/update-acorn.sh must be // Refer to tools/dep_updaters/update-acorn.sh

Changes needed in deps_update/update_.sh scripts
@MrJithil
Copy link
Member Author

Please help me to add the label good first issue

@panva panva added the good first issue Issues that are suitable for first-time contributors. label Oct 12, 2023
This was referenced Oct 12, 2023
Closed
Merged
@sk-pathak
Copy link

can you assign this to me?

aduh95 pushed a commit that referenced this issue Oct 12, 2023
@Keksonoid
tools: fix comments referencing dep_updaters scripts
766198b 
PR-URL: #50165
Fixes: #50159
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@pluris pluris mentioned this issue Oct 13, 2023
Merged
aduh95 pushed a commit that referenced this issue Oct 15, 2023
tools: update comment in update-uncidi.sh and acorn_version.h
f09a50c 
PR-URL: #50175
Fixes: #50159
Refs: #50165
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
kumarrishav pushed a commit to kumarrishav/node that referenced this issue Oct 16, 2023
@kumarrishav
tools: update comment in update-uncidi.sh and acorn_version.h
8bba0df 
PR-URL: nodejs#50175
Fixes: nodejs#50159
Refs: nodejs#50165
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos pushed a commit that referenced this issue Oct 23, 2023
@targos
tools: update comment in update-uncidi.sh and acorn_version.h
5df3d5a 
PR-URL: #50175
Fixes: #50159
Refs: #50165
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
@Keksonoid @alexfernandez
tools: fix comments referencing dep_updaters scripts
b388426 
PR-URL: nodejs#50165
Fixes: nodejs#50159
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
@alexfernandez
tools: update comment in update-uncidi.sh and acorn_version.h
72bb5bc 
PR-URL: nodejs#50175
Fixes: nodejs#50159
Refs: nodejs#50165
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos pushed a commit that referenced this issue Nov 11, 2023
@Keksonoid @targos
tools: fix comments referencing dep_updaters scripts
b959d36 
PR-URL: #50165
Fixes: #50159
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos pushed a commit that referenced this issue Nov 11, 2023
@targos
tools: update comment in update-uncidi.sh and acorn_version.h
05ee350 
PR-URL: #50175
Fixes: #50159
Refs: #50165
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
4 participants
@panva @MrJithil @sk-pathak and others