Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path.resolve across drives in Windows #50

Closed
ankurp opened this issue Dec 3, 2014 · 3 comments · May be fixed by enterstudio/node#27, solebox/node#30 or s4sc/node#27
Closed

path.resolve across drives in Windows #50

ankurp opened this issue Dec 3, 2014 · 3 comments · May be fixed by enterstudio/node#27, solebox/node#30 or s4sc/node#27
Labels
windows Issues and PRs related to the Windows platform.

Comments

@ankurp
Copy link

ankurp commented Dec 3, 2014

The path does not resolve correctly when resolving from one drive to another drive in windows using path.resolve
@rvagg
Copy link
Member

rvagg commented Dec 3, 2014

@ankurp can you provide more information on this please? An example would be good, preferably something that could be turned into a test case (as difficult as the set-up for that will be). You could even consider contributing a test case to test/simple/

@ankurp
Copy link
Author

ankurp commented Dec 3, 2014

Will do.

@ankurp ankurp mentioned this issue Dec 4, 2014
Closed
@Fishrock123 Fishrock123 added the windows Issues and PRs related to the Windows platform. label Jan 22, 2015
@brendanashworth
Copy link
Contributor

It seems as if pull request #57 has been closed due to downvotes against the idea that this issue puts forward, so I think this should be closed.

@rupamkhaitan rupamkhaitan mentioned this issue Jun 27, 2016
Closed
@bengl bengl mentioned this issue Jul 27, 2016
Closed
@TonyPythoneer TonyPythoneer mentioned this issue Aug 10, 2016
Closed
@ALJCepeda ALJCepeda mentioned this issue Sep 21, 2016
Closed
@coolaj86 coolaj86 mentioned this issue Sep 29, 2016
Closed
@bibitiger bibitiger mentioned this issue Dec 2, 2016
Closed
@jasonwilliams jasonwilliams mentioned this issue Nov 22, 2017
Closed
@fs-eire fs-eire mentioned this issue Dec 22, 2017
Closed
@nodeav nodeav mentioned this issue Mar 25, 2018
Closed
@octaviansoldea octaviansoldea mentioned this issue Jul 5, 2018
Closed
@MasterJames MasterJames mentioned this issue Apr 13, 2019
Closed
This was referenced May 2, 2019
Closed
Closed
@joyeecheung joyeecheung mentioned this issue Feb 20, 2020
Closed
@wmertens wmertens mentioned this issue Jun 19, 2020
Closed
@silverwind silverwind mentioned this issue Aug 20, 2020
Closed
@verhovsky verhovsky mentioned this issue Mar 12, 2021
Closed
targos added a commit to targos/node that referenced this issue Apr 17, 2021
@targos
deps: V8: cherry-pick eddb82330975
d85b52b 
Original commit message:

    Merged: [wasm][liftoff] Fix register usage for i64_addi

    The arm implementation made the assumption that the {lhs} and {dst}
    registers are either the same, or there is no overlap. This assumption
    does not hold.
    ia32 on the other hand has a lot of complicated logic (and unnecessary
    code generation) for different cases of overlap.

    This CL fixes the arm issue *and* simplifies the ia32 logic by making
    the arm assumption hold, and using it to eliminate special handling on
    ia32.

    R=​thibaudm@chromium.org

    (cherry picked from commit 89ca48c907e25ef94a135255092c4e150654c4fc)

    Bug: chromium:1146861
    Change-Id: I96c4985fb8ff710b98e009e457444fc8804bce58
    No-Try: true
    No-Presubmit: true
    No-Tree-Checks: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2584242
    Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/branch-heads/8.6@{nodejs#50}
    Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1}
    Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472}

Refs: v8/v8@eddb823
targos added a commit to targos/node that referenced this issue Apr 27, 2021
@targos
deps: V8: cherry-pick eddb82330975
02584c6 
Original commit message:

    Merged: [wasm][liftoff] Fix register usage for i64_addi

    The arm implementation made the assumption that the {lhs} and {dst}
    registers are either the same, or there is no overlap. This assumption
    does not hold.
    ia32 on the other hand has a lot of complicated logic (and unnecessary
    code generation) for different cases of overlap.

    This CL fixes the arm issue *and* simplifies the ia32 logic by making
    the arm assumption hold, and using it to eliminate special handling on
    ia32.

    R=​thibaudm@chromium.org

    (cherry picked from commit 89ca48c907e25ef94a135255092c4e150654c4fc)

    Bug: chromium:1146861
    Change-Id: I96c4985fb8ff710b98e009e457444fc8804bce58
    No-Try: true
    No-Presubmit: true
    No-Tree-Checks: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2584242
    Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/branch-heads/8.6@{nodejs#50}
    Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1}
    Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472}

Refs: v8/v8@eddb823
targos added a commit that referenced this issue Apr 30, 2021
@targos
deps: V8: cherry-pick eddb82330975
42140a1 
Original commit message:

    Merged: [wasm][liftoff] Fix register usage for i64_addi

    The arm implementation made the assumption that the {lhs} and {dst}
    registers are either the same, or there is no overlap. This assumption
    does not hold.
    ia32 on the other hand has a lot of complicated logic (and unnecessary
    code generation) for different cases of overlap.

    This CL fixes the arm issue *and* simplifies the ia32 logic by making
    the arm assumption hold, and using it to eliminate special handling on
    ia32.

    R=​thibaudm@chromium.org

    (cherry picked from commit 89ca48c907e25ef94a135255092c4e150654c4fc)

    Bug: chromium:1146861
    Change-Id: I96c4985fb8ff710b98e009e457444fc8804bce58
    No-Try: true
    No-Presubmit: true
    No-Tree-Checks: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2584242
    Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/branch-heads/8.6@{#50}
    Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1}
    Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472}

Refs: v8/v8@eddb823

PR-URL: #38275
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
@enterstudio enterstudio mentioned this issue May 13, 2022
Open
@solebox solebox mentioned this issue May 14, 2022
Open
@s4sc s4sc mentioned this issue May 14, 2022
Open
@nickfnblum nickfnblum mentioned this issue Nov 30, 2023
Open
@dewaynesmith3711 dewaynesmith3711 mentioned this issue Nov 30, 2023
Open
@xphillyx xphillyx mentioned this issue Nov 30, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this issue Dec 1, 2023
Open
@kaocher82 kaocher82 mentioned this issue Dec 1, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this issue Dec 1, 2023
Open
@gr00nd gr00nd mentioned this issue Feb 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
7 participants
@piscisaureus @bnoordhuis @rvagg @ankurp @Fishrock123 @brendanashworth @caineio