-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIGNAL USERS READ THIS FIRST: code: 'ERR_INTERNAL_ASSERTION' in internalConnectMultiple #47644
Comments
Based on the stack trace, it looks similar to #46669 and #46670, so possibly related to #44731, #46587. cc @ShogunPanda |
@tniessen It seems so. I'll take a look soon |
I'm also seeing a similar issue with ssh2 after upgrading to Node 20. Repro steps:
client.connect({
host: 'yahoo.com',
port: 22,
username: 'bob',
password: 'secret'
})
// Adding this line crashes the process.
client.on('error', () => {}) |
seeing this issue as well on production Error [ERR_INTERNAL_ASSERTION]: This is caused by either a bug in Node.js or incorrect usage of Node.js internals. | 2023-04-29T13:32:31.670-04:00 | Please open an issue with this stack trace at https://github.com/nodejs/node/issues Our old build from 10 days ago still works, but all new builds seem to run into this issue. |
Just a note, subscribing as still present in In a net and async/await heavy program:
|
This might be fixed by #47860. |
@kamagatos @yuki12321 The PR above has landed in master. If you can compile Node locally, do you mind checking it if solves your issues as well? |
I now see the following on
|
@MikeRalphson Can you please provide a repro file, along with the |
The same internal assertion is causing CI to fail on Fedora machines, see #48000. However, it is not the Side note: the main branch is called |
This randomly started happening on my production build after a deployment. I'm using lts-alpine image in my docker file, has there been a recent change that could be causing this? |
@brandon-beacher It's the network family auto selection which was enabled by default in 20.0.0. |
This is still an issue in Node.js 20.2.0. As a workaround, you can try restoring the more predictable pre-20 behavior by setting this environment variable: NODE_OPTIONS="--no-network-family-autoselection" |
this happened when i open signal app on mac laptop. has this been fixed? thanks. |
@arllop If Signal does not override |
Have been redirected here as per my closed duplicated ticket. So as I understand it this is still an active issue in v20.4 and is related to the network area with the current solutions being to: I have been redirected here but this is also closed so presumably the best place to follow as to when ^v20 is usable is now #48763 #request/request#3458 I can confirm that going back to v19 resolves this issue in production for me. |
@dmcr can you please provide a repro repo or at least which host are you trying to connect to and how your DNS resolves such host? |
PR-URL: nodejs#48464 Fixes: npm/cli#6409 Fixes: KararTY/dank-twitch-irc#13 Fixes: nodejs#47644 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: nodejs#48464 Fixes: npm/cli#6409 Fixes: KararTY/dank-twitch-irc#13 Fixes: nodejs#47644 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Issue still occurring for node 20.5.1 with the same stacktrace. |
@Rand0mF In order to address this, I need to know which host your node app is connecting to and how your local (or Kubernetes system) is resolving it. Can you provide me such info? |
@ShogunPanda Unfortunately I don't know.. The app is doing many queries to all kinds of hosts. The error logs don't provide any useful information for that, that's the only thing which is printed. Reverse engineering is difficult as it seems to occur completely at random, I didn't yet find a way to reproduce it.
|
Very sporadic error which seems to be difficult to debug locally as @Rand0mF mentioned. |
@ainsleyclark Is the same for you? Can you provide a list of which hosts the production system is connecting to and how these are resolved by the production system DNS servers? |
I'm seeing lots of these errors too, on Node v20.8.0. Similar to other reports, it seems to be very intermittent and only happening under load. I can't confirm the addresses involved either unfortunately (software is running on end user machines, I just see exception reports). |
@ShogunPanda cluster-external hosts
cluster-internal hosts
any other flags which would be helpful? |
Nope, that should be it. I will keep you posted. |
Still experiencing the issue with Node 20^. Switching to Node 18 solves the problem for me. |
This should be solved by #51045. Will keep you as soon as this reaches 20.x. |
Any updates on when this is going to be fixed for 20.x @ShogunPanda ? |
It has been for a long time @guillenotfound https://nodejs.org/en/blog/release/v20.12.0#new-connection-attempt-events. |
@guillenotfound It has been release in 20.12.0. |
Version
20.0.0
Platform
Darwin MacBookPro.local 22.3.0 Darwin Kernel Version 22.3.0: Mon Jan 30 20:42:11 PST 2023; root:xnu-8792.81.3~2/RELEASE_X86_64 x86_64
Subsystem
No response
What steps will reproduce the bug?
I ran the Storybook installation on Next.js 13.3.0 and this is what I see.
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior? Why is that the expected behavior?
No response
What do you see instead?
Additional information
No response
The text was updated successfully, but these errors were encountered: