Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky parallel/test-process-wrap on macos #45805

Closed
bnoordhuis opened this issue Dec 10, 2022 · 0 comments · Fixed by #45806
Closed

Investigate flaky parallel/test-process-wrap on macos #45805

bnoordhuis opened this issue Dec 10, 2022 · 0 comments · Fixed by #45806
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@bnoordhuis
Copy link
Member

Seems to time out frequently as of late.

12:08:43 not ok 2473 parallel/test-process-wrap
12:08:43   ---
12:08:43   duration_ms: 120.72
12:08:43   severity: fail
12:08:43   exitcode: -15
12:08:43   stack: |-
12:08:43     timeout
12:08:43     (node:25456) internal/test/binding: These APIs are for internal testing only. Do not use them.
12:08:43     (Use `node --trace-warnings ...` to show where the warning was created)

Example run: https://ci.nodejs.org/job/node-test-commit-osx/49092/nodes=osx1015/console

It's a really old test (f01b241 from 2011) that's testing internal implementation details that don't need testing so maybe it should just go.
@bnoordhuis bnoordhuis added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Dec 10, 2022
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Dec 10, 2022
@bnoordhuis
test: remove flaky parallel/test-process-wrap test
31af79d 
It's an old test (added when switching from libev to libuv) that tests
implementation details of the internal process_wrap bindings. That kind
of thing doesn't need testing in this day and age, and since the test is
flaky, simply remove it instead of sinking time in fixing it up.

Fixes: nodejs#45805
@bnoordhuis bnoordhuis mentioned this issue Dec 10, 2022
Merged
nodejs-github-bot pushed a commit that referenced this issue Dec 12, 2022
@bnoordhuis
test: remove flaky parallel/test-process-wrap test
74a6f0b 
It's an old test (added when switching from libev to libuv) that tests
implementation details of the internal process_wrap bindings. That kind
of thing doesn't need testing in this day and age, and since the test is
flaky, simply remove it instead of sinking time in fixing it up.

Fixes: #45805
PR-URL: #45806
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ErickWendel pushed a commit to ErickWendel/node that referenced this issue Dec 12, 2022
@bnoordhuis @ErickWendel
test: remove flaky parallel/test-process-wrap test
c7b9d1a 
It's an old test (added when switching from libev to libuv) that tests
implementation details of the internal process_wrap bindings. That kind
of thing doesn't need testing in this day and age, and since the test is
flaky, simply remove it instead of sinking time in fixing it up.

Fixes: nodejs#45805
PR-URL: nodejs#45806
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this issue Dec 12, 2022
@bnoordhuis @targos
test: remove flaky parallel/test-process-wrap test
e8406a8 
It's an old test (added when switching from libev to libuv) that tests
implementation details of the internal process_wrap bindings. That kind
of thing doesn't need testing in this day and age, and since the test is
flaky, simply remove it instead of sinking time in fixing it up.

Fixes: #45805
PR-URL: #45806
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this issue Dec 13, 2022
@bnoordhuis @targos
test: remove flaky parallel/test-process-wrap test
b297dd5 
It's an old test (added when switching from libev to libuv) that tests
implementation details of the internal process_wrap bindings. That kind
of thing doesn't need testing in this day and age, and since the test is
flaky, simply remove it instead of sinking time in fixing it up.

Fixes: #45805
PR-URL: #45806
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
@bnoordhuis @danielleadams
test: remove flaky parallel/test-process-wrap test
223f3c1 
It's an old test (added when switching from libev to libuv) that tests
implementation details of the internal process_wrap bindings. That kind
of thing doesn't need testing in this day and age, and since the test is
flaky, simply remove it instead of sinking time in fixing it up.

Fixes: #45805
PR-URL: #45806
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
@bnoordhuis @danielleadams
test: remove flaky parallel/test-process-wrap test
c93820d 
It's an old test (added when switching from libev to libuv) that tests
implementation details of the internal process_wrap bindings. That kind
of thing doesn't need testing in this day and age, and since the test is
flaky, simply remove it instead of sinking time in fixing it up.

Fixes: #45805
PR-URL: #45806
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this issue Jan 3, 2023
@bnoordhuis @danielleadams
test: remove flaky parallel/test-process-wrap test
7e386f8 
It's an old test (added when switching from libev to libuv) that tests
implementation details of the internal process_wrap bindings. That kind
of thing doesn't need testing in this day and age, and since the test is
flaky, simply remove it instead of sinking time in fixing it up.

Fixes: #45805
PR-URL: #45806
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this issue Jan 4, 2023
@bnoordhuis @danielleadams
test: remove flaky parallel/test-process-wrap test
cb745f9 
It's an old test (added when switching from libev to libuv) that tests
implementation details of the internal process_wrap bindings. That kind
of thing doesn't need testing in this day and age, and since the test is
flaky, simply remove it instead of sinking time in fixing it up.

Fixes: #45805
PR-URL: #45806
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this issue Jan 5, 2023
@bnoordhuis @danielleadams
test: remove flaky parallel/test-process-wrap test
f762ed2 
It's an old test (added when switching from libev to libuv) that tests
implementation details of the internal process_wrap bindings. That kind
of thing doesn't need testing in this day and age, and since the test is
flaky, simply remove it instead of sinking time in fixing it up.

Fixes: #45805
PR-URL: #45806
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: remove flaky parallel/test-process-wrap test bnoordhuis/io.js
1 participant
@bnoordhuis