Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is IncomingMessage.destroy method not documented? #4226

Closed
simov opened this issue Dec 10, 2015 · 6 comments
Closed

Why is IncomingMessage.destroy method not documented? #4226

simov opened this issue Dec 10, 2015 · 6 comments
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. question Issues that look for answers.

Comments

@simov
Copy link
Contributor

simov commented Dec 10, 2015

https://github.com/nodejs/node/blob/v5.2.0/lib/_http_incoming.js#L89-L95
@simov simov mentioned this issue Dec 10, 2015
Merged
@mscdex mscdex added question Issues that look for answers. http Issues or PRs related to the http subsystem. labels Dec 10, 2015
@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Dec 14, 2015
@Fishrock123
Copy link
Contributor

cc @nodejs/http

@indutny
Copy link
Member

indutny commented Dec 14, 2015

@Fishrock123 does anyone actually use it? It was contributed in 8139bb2

@hueniverse
Copy link

I think we call it indirectly in hapi and wreck. When you call res.destroy() does it lead to that one?

@indutny
Copy link
Member

indutny commented Dec 14, 2015

@hueniverse nope, it does not use req.destroy().

@mscdex
Copy link
Contributor

mscdex commented Dec 14, 2015

I think this would be for an http client's server response or an http server's client requests. I suppose it might be helpful to document it since it can be useful.

@mcollina mcollina mentioned this issue Dec 23, 2015
Closed
@Trott Trott mentioned this issue Jun 8, 2016
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Jun 8, 2016

#7237

Trott added a commit to Trott/io.js that referenced this issue Jun 12, 2016
@Trott
doc: add information for IncomingMessage.destroy()
20ab480 
Add documentation for `http.IncomingMessage.prototype.destroy()`.

Fixes: nodejs#4226
@Trott Trott closed this as completed in 4f2aec3 Jun 12, 2016
evanlucas pushed a commit that referenced this issue Jun 16, 2016
@Trott @evanlucas
doc: add information for IncomingMessage.destroy()
5d03bdd 
Add documentation for `http.IncomingMessage.prototype.destroy()`.

PR-URL: #7237
Fixes: #4226
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this issue Jul 12, 2016
@Trott @addaleax
doc: add information for IncomingMessage.destroy()
2a29c4b 
Add documentation for `http.IncomingMessage.prototype.destroy()`.

PR-URL: nodejs#7237
Fixes: nodejs#4226
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Jul 12, 2016
@Trott
doc: add information for IncomingMessage.destroy()
4be64bf 
Add documentation for `http.IncomingMessage.prototype.destroy()`.

PR-URL: #7237
Fixes: #4226
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Jul 12, 2016
@Trott
doc: add information for IncomingMessage.destroy()
4043d41 
Add documentation for `http.IncomingMessage.prototype.destroy()`.

PR-URL: #7237
Fixes: #4226
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Jul 14, 2016
@Trott
doc: add information for IncomingMessage.destroy()
3c300c7 
Add documentation for `http.IncomingMessage.prototype.destroy()`.

PR-URL: #7237
Fixes: #4226
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Jul 14, 2016
@Trott
doc: add information for IncomingMessage.destroy()
60c054b 
Add documentation for `http.IncomingMessage.prototype.destroy()`.

PR-URL: #7237
Fixes: #4226
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
This was referenced Oct 16, 2020
Merged
Open
Open
This was referenced Nov 18, 2020
Merged
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. question Issues that look for answers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add information for IncomingMessage.destroy() Trott/io.js
6 participants
@mscdex @hueniverse @indutny @Trott @Fishrock123 @simov