Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-dns-promises-lookupService assumes getnameinfo can return named service #42164

Closed
kapouer opened this issue Mar 1, 2022 · 0 comments · Fixed by #42596
Closed

test-dns-promises-lookupService assumes getnameinfo can return named service #42164

kapouer opened this issue Mar 1, 2022 · 0 comments · Fixed by #42596
Labels
test Issues and PRs related to the tests.

Comments

@kapouer
Copy link
Contributor

kapouer commented Mar 1, 2022

Version

HEAD

Platform

No response

Subsystem

test

What steps will reproduce the bug?

node test/parallel/test-dns-lookupService-promises.js

How often does it reproduce? Is there a required condition?

On a clean linux chroot without /etc/services (which is provided by nonessential netbase package, not guaranteed to be installed)

What is the expected behavior?

Test should allow dnsPromises.lookupService('127.0.0.1', 22) to return service with 22 or 'ssh'.

What do you see instead?

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
'22' !== 'ssh'
at /tmp/autopkgtest.2FaIUP/build.wly/src/test/parallel/test-dns-lookupService-promises.js:9:10

Additional information

It's the only test assuming getnameinfo will return the service name.
@meixg meixg added the test Issues and PRs related to the tests. label Mar 1, 2022
daeyeon added a commit to daeyeon/node that referenced this issue Apr 4, 2022
@daeyeon
test: allow numeric string for lookupService test
385fd01 
Fixes: nodejs#42164

If the given port number isn't associated with any service name,
the `service` resolved from `dns.lookupService` can be a numeric
string representing the port number.
@daeyeon daeyeon mentioned this issue Apr 4, 2022
Merged
daeyeon added a commit to daeyeon/node that referenced this issue Apr 4, 2022
@daeyeon
test: allow numeric string for lookupService test
3031525 
Fixes: nodejs#42164

If the given port number isn't associated with any service name,
the `service` resolved from `dns.lookupService` can be a numeric
string representing the port number.
nodejs-github-bot pushed a commit that referenced this issue Apr 12, 2022
@daeyeon
test: allow numeric string for lookupService test
db7fa9f 
Fixes: #42164

If the given port number isn't associated with any service name,
the `service` resolved from `dns.lookupService` can be a numeric
string representing the port number.

PR-URL: #42596
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
xtx1130 pushed a commit to xtx1130/node that referenced this issue Apr 25, 2022
@daeyeon @xtx1130
test: allow numeric string for lookupService test
c1c8d88 
Fixes: nodejs#42164

If the given port number isn't associated with any service name,
the `service` resolved from `dns.lookupService` can be a numeric
string representing the port number.

PR-URL: nodejs#42596
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
juanarbol pushed a commit that referenced this issue May 31, 2022
@daeyeon @juanarbol
test: allow numeric string for lookupService test
567b96a 
Fixes: #42164

If the given port number isn't associated with any service name,
the `service` resolved from `dns.lookupService` can be a numeric
string representing the port number.

PR-URL: #42596
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this issue Jun 27, 2022
@daeyeon @danielleadams
test: allow numeric string for lookupService test
e93954b 
Fixes: #42164

If the given port number isn't associated with any service name,
the `service` resolved from `dns.lookupService` can be a numeric
string representing the port number.

PR-URL: #42596
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos pushed a commit that referenced this issue Jul 11, 2022
@daeyeon @targos
test: allow numeric string for lookupService test
fbbab9b 
Fixes: #42164

If the given port number isn't associated with any service name,
the `service` resolved from `dns.lookupService` can be a numeric
string representing the port number.

PR-URL: #42596
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos pushed a commit that referenced this issue Jul 31, 2022
@daeyeon @targos
test: allow numeric string for lookupService test
a38c122 
Fixes: #42164

If the given port number isn't associated with any service name,
the `service` resolved from `dns.lookupService` can be a numeric
string representing the port number.

PR-URL: #42596
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Oct 10, 2022
@daeyeon @guangwong
test: allow numeric string for lookupService test
02feae2 
Fixes: nodejs/node#42164

If the given port number isn't associated with any service name,
the `service` resolved from `dns.lookupService` can be a numeric
string representing the port number.

PR-URL: nodejs/node#42596
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: allow numeric string for lookupService test daeyeon/node
2 participants
@kapouer @meixg