Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: undo typing in REPL #41308

Closed
rayw000 opened this issue Dec 24, 2021 · 0 comments · Fixed by #41392
Closed

readline: undo typing in REPL #41308

rayw000 opened this issue Dec 24, 2021 · 0 comments · Fixed by #41392
Labels
feature request Issues that request new features to be added to Node.js. readline Issues and PRs related to the built-in readline module.

Comments

@rayw000
Copy link
Contributor

rayw000 commented Dec 24, 2021 •
edited
Loading

Undo REPL typing and bind to Ctrl-/ like what zsh and bash do.

I'd like to contribute this feature.
@rayw000 rayw000 added the feature request Issues that request new features to be added to Node.js. label Dec 24, 2021
@VoltrexKeyva VoltrexKeyva added the readline Issues and PRs related to the built-in readline module. label Dec 24, 2021
@Mesteery Mesteery added repl Issues and PRs related to the REPL subsystem. and removed readline Issues and PRs related to the built-in readline module. labels Dec 29, 2021
@rayw000 rayw000 mentioned this issue Jan 4, 2022
Merged
@Mesteery Mesteery added readline Issues and PRs related to the built-in readline module. and removed repl Issues and PRs related to the REPL subsystem. labels Jan 4, 2022
nodejs-github-bot pushed a commit that referenced this issue Jan 21, 2022
@rayw000
readline: undo previous edit when get key code 0x1F
271725a 
1. Undo previous edit on keystroke `ctrl -` (emit 0x1F)
2. unittests
3. documentation

PR-URL: #41392
Fixes: #41308
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
BethGriggs pushed a commit that referenced this issue Jan 25, 2022
@rayw000 @BethGriggs
readline: undo previous edit when get key code 0x1F
5a4c74c 
1. Undo previous edit on keystroke `ctrl -` (emit 0x1F)
2. unittests
3. documentation

PR-URL: #41392
Fixes: #41308
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this issue Jan 31, 2022
@rayw000 @Linkgoron
readline: undo previous edit when get key code 0x1F
42c178a 
1. Undo previous edit on keystroke `ctrl -` (emit 0x1F)
2. unittests
3. documentation

PR-URL: nodejs#41392
Fixes: nodejs#41308
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

readline: undo previous edit when get key code 0x1F
3 participants
@Mesteery @VoltrexKeyva @rayw000