Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto.sign swallows OpenSSL errors #40794

Closed
tniessen opened this issue Nov 12, 2021 · 0 comments · Fixed by #40796
Closed

crypto.sign swallows OpenSSL errors #40794

tniessen opened this issue Nov 12, 2021 · 0 comments · Fixed by #40796
Labels
confirmed-bug Issues with confirmed bugs. crypto Issues and PRs related to the crypto subsystem.

Comments

@tniessen
Copy link
Member

Version

current

Platform

all

Subsystem

crypto

What steps will reproduce the bug?

crypto.sign('sha512', '', crypto.generateKeyPairSync('rsa', { modulusLength: 512 }).privateKey)

How often does it reproduce? Is there a required condition?

One of the internal OpenSSL calls must fail, in this case, due to incompatible digest and modulus length.

What is the expected behavior?

A useful error message.

What do you see instead?

Uncaught Error: Deriving bits failed
    at Object.signOneShot [as sign] (node:internal/crypto/sig:181:42)

Additional information

No response
@tniessen tniessen added confirmed-bug Issues with confirmed bugs. crypto Issues and PRs related to the crypto subsystem. labels Nov 12, 2021
tniessen added a commit to tniessen/node that referenced this issue Nov 12, 2021
@tniessen
crypto: throw errors in SignTraits::DeriveBits
0ef6a0b 
Fixes: nodejs#40794
@tniessen tniessen mentioned this issue Nov 12, 2021
Merged
nodejs-github-bot pushed a commit that referenced this issue Nov 15, 2021
@tniessen
crypto: throw errors in SignTraits::DeriveBits
d049a52 
Fixes: #40794

PR-URL: #40796
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Nov 21, 2021
@tniessen @targos
crypto: throw errors in SignTraits::DeriveBits
2979c58 
Fixes: #40794

PR-URL: #40796
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this issue Jan 30, 2022
@tniessen @danielleadams
crypto: throw errors in SignTraits::DeriveBits
90ce19d 
Fixes: #40794

PR-URL: #40796
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this issue Feb 1, 2022
@tniessen @danielleadams
crypto: throw errors in SignTraits::DeriveBits
e60841b 
Fixes: #40794

PR-URL: #40796
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

crypto: throw errors in SignTraits::DeriveBits tniessen/node
1 participant
@tniessen