Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small-icu broken? #40209

Closed
srl295 opened this issue Sep 24, 2021 · 4 comments
Closed

small-icu broken? #40209

srl295 opened this issue Sep 24, 2021 · 4 comments
Assignees
Labels
i18n-api Issues and PRs related to the i18n implementation.

Comments

@srl295
Copy link
Member

srl295 commented Sep 24, 2021

Version

8006586

Platform

Darwin abeja 20.6.0 Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:21 PDT 2021; root:xnu-7195.141.6~3/RELEASE_X86_64 x86_64

Subsystem

intl

What steps will reproduce the bug?

configure --with-intl=small-icu --ninja
ninja

How often does it reproduce? Is there a required condition?

always

What is the expected behavior?

:

What do you see instead?

ninja: Entering directory `out/Release'
[1/788] ACTION icudata: icutrim_cc7672230cb6f4a4cb1b079ff599d36f
FAILED: gen/icutmp/icudt69l.dat
cd ../../tools/icu; export BUILT_FRAMEWORKS_DIR=/Users/srl295/src/node/out/Release; export BUILT_PRODUCTS_DIR=/Users/srl295/src/node/out/Release; export CONFIGURATION=Release; export EXECUTABLE_NAME=libicudata.a; export EXECUTABLE_PATH=libicudata.a; export FULL_PRODUCT_NAME=libicudata.a; export MACH_O_TYPE=staticlib; export PRODUCT_NAME=icudata; export PRODUCT_TYPE=com.apple.product-type.library.static; export SDKROOT=/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk; export SRCROOT=/Users/srl295/src/node/out/Release/../../tools/icu; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Users/srl295/src/node/out/Release; export TEMP_DIR="${TMPDIR}"; export XCODE_VERSION_ACTUAL=1300;python icutrim.py -P ../../out/Release -D ../../deps/icu-tmp/icudt69l.dat --delete-tmp -T ../../out/Release/gen/icutmp -F icu_small.json -O icudt69l.dat -v -L en,root
Options: {'verbose': 1, 'filterfile': 'icu_small.json', 'toolpath': '../../out/Release', 'deltmpdir': 1, 'outfile': 'icudt69l.dat', 'datfile': '../../deps/icu-tmp/icudt69l.dat', 'locales': 'en,root', 'endian': 'little', 'tmpdir': '../../out/Release/gen/icutmp'}
icu_small.json: icutrim.py config: Trim down ICU to just a certain locale set, needed for node.js use.
* converters: 190 items
* stringprep: 12 items
* translit: 3 items
* brkfiles: 12 items
* brkdict: 5 items
* confusables: 1 items
* brkitr: 13 items
* coll: 138 items
* curr: 493 items
* lang: 422 items
Removing lang/pool.res because tree lang is empty.
* rbnf: 99 items
* region: 422 items
Removing region/pool.res because tree region is empty.
* ROOT: 784 items
* unit: 413 items
* zone: 422 items
Traceback (most recent call last):
  File "icutrim.py", line 339, in <module>
    removeList(1)
  File "icutrim.py", line 319, in removeList
    pat = re.compile(bytes(r"^Item ([^ ]+) depends on missing item ([^ ]+).*", 'utf-8'))
TypeError: str() takes at most 1 argument (2 given)
ninja: build stopped: subcommand failed.

Additional information

maybe time for #25136

@srl295 srl295 self-assigned this Sep 24, 2021
@srl295 srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Sep 24, 2021
@srl295
Copy link
Member Author

srl295 commented Sep 24, 2021

Node.js configure: Found Python 3.9.7...

srl295 added a commit to srl295/node that referenced this issue Sep 24, 2021
srl295 referenced this issue Sep 24, 2021
PR-URL: #31659
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@srl295
Copy link
Member Author

srl295 commented Sep 24, 2021

of course, I had approved #31659 but that was a long time ago

@Segfaultd
Copy link

Hey there @srl295 is there any plan to get the PR merged? Or is the lil hack recommended way of building? :D

@srl295
Copy link
Member Author

srl295 commented Apr 4, 2023

Fixed by #4161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Development

No branches or pull requests

2 participants