Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler failure with VS 2022 and V8 9.3 #39976

Closed
targos opened this issue Sep 2, 2021 · 1 comment
Closed

Compiler failure with VS 2022 and V8 9.3 #39976

targos opened this issue Sep 2, 2021 · 1 comment
Labels
v8 engine Issues and PRs related to the V8 dependency. windows Issues and PRs related to the Windows platform.

Comments

@targos
Copy link
Member

targos commented Sep 2, 2021

Unfortunately, #39857 landed after the V8 9.3 update, but tests were run when our code was still on V8 9.2.

Error:

     Creating library ..\..\out\Release\mksnapshot.lib and object ..\..\out\Release\mksnapshot.exp
mksnapshot.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::FixedArray::set(int,class v8::internal::Smi)" (?set@FixedArray@internal@v8@@QEAAXHVSmi@23@@Z) [D:\a\node\node\tools\v8_gypfiles\mksnapshot.vcxproj]
platform-embedded-file-writer-aix.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::FixedArray::set(int,class v8::internal::Smi)" (?set@FixedArray@internal@v8@@QEAAXHVSmi@23@@Z) [D:\a\node\node\tools\v8_gypfiles\mksnapshot.vcxproj]
platform-embedded-file-writer-generic.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::FixedArray::set(int,class v8::internal::Smi)" (?set@FixedArray@internal@v8@@QEAAXHVSmi@23@@Z) [D:\a\node\node\tools\v8_gypfiles\mksnapshot.vcxproj]
platform-embedded-file-writer-mac.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::FixedArray::set(int,class v8::internal::Smi)" (?set@FixedArray@internal@v8@@QEAAXHVSmi@23@@Z) [D:\a\node\node\tools\v8_gypfiles\mksnapshot.vcxproj]
platform-embedded-file-writer-win.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::FixedArray::set(int,class v8::internal::Smi)" (?set@FixedArray@internal@v8@@QEAAXHVSmi@23@@Z) [D:\a\node\node\tools\v8_gypfiles\mksnapshot.vcxproj]
..\..\out\Release\mksnapshot.exe : fatal error LNK1120: 1 unresolved externals [D:\a\node\node\tools\v8_gypfiles\mksnapshot.vcxproj]

GitHub actions logs: https://github.com/nodejs/node/runs/3489315814

/cc @nodejs/v8 I'll open a revert PR if we cannot resolve this quickly.

@targos targos added windows Issues and PRs related to the Windows platform. v8 engine Issues and PRs related to the V8 dependency. labels Sep 2, 2021
targos added a commit to targos/node that referenced this issue Sep 3, 2021
This reverts commit 13b569c.

V8 9.3 is not compatible.

Refs: nodejs#39976
nodejs-github-bot pushed a commit that referenced this issue Sep 3, 2021
This reverts commit 13b569c.

V8 9.3 is not compatible.

Refs: #39976

PR-URL: #39982
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this issue Sep 6, 2021
This reverts commit 13b569c.

V8 9.3 is not compatible.

Refs: #39976

PR-URL: #39982
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this issue Sep 6, 2021
This reverts commit 13b569c.

V8 9.3 is not compatible.

Refs: #39976

PR-URL: #39982
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos closed this as completed Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

2 participants
@targos and others