-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSStream ReadStream Assertion Failure #3970
Comments
/cc @indutny |
Will look into it tomorrow. |
The fix is here, but you won't be happy with it. Basically, TLS can't be established on connection after But it should not segfault on this, so it is still kind of a bugfix. |
Yeah, I knew it was /wrong/, and I am indeed not happy, but that's my problem, not yours. Your (where you = Node.js) problem is the segfault. |
If `.setEncoding` was called on input stream - all emitted `data` will be `String`s instances, not `Buffer`s. This is unacceptable for `StreamWrap`, and should not lead to the crash. Fix: nodejs#3970
If `.setEncoding` was called on input stream - all emitted `data` will be `String`s instances, not `Buffer`s. This is unacceptable for `StreamWrap`, and should not lead to the crash. Fix: nodejs#3970 PR-URL: nodejs#4031 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Minimal test case:
Results in:
Note that the
setEncoding
call is the crucial bit.The text was updated successfully, but these errors were encountered: