Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf_hooks.monitorEventLoopDelay results in an abort #38160

Closed
zyscoder opened this issue Apr 9, 2021 · 1 comment
Closed

perf_hooks.monitorEventLoopDelay results in an abort #38160

zyscoder opened this issue Apr 9, 2021 · 1 comment
Labels
confirmed-bug Issues with confirmed bugs. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.

Comments

@zyscoder
Copy link

zyscoder commented Apr 9, 2021

What steps will reproduce the bug?

Setup a node instance,

» node

and run the following javascript code.

perf_hooks.monitorEventLoopDelay({resolution:2147483648})

Then an abort occurs.

How often does it reproduce? Is there a required condition?

This problem can always be triggered following the steps above.

What is the expected behavior?

If any error occurs, an exception or other similar error-reporting stuff should be thrown. There is no reason to abort the whole node process.

What do you see instead?

» node
Welcome to Node.js v14.15.1.
Type ".help" for more information.
> perf_hooks.monitorEventLoopDelay({resolution:2147483648})
node[802902]: ../src/node_perf.cc:483:void node::performance::{anonymous}::ELDHistogramNew(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `(resolution) > (0)' failed.
 1: 0xa03530 node::Abort() [node]
 2: 0xa035ae  [node]
 3: 0xa6d5ea  [node]
 4: 0xbe4695  [node]
 5: 0xbe4c9f  [node]
 6: 0xbe52c6 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [node]
 7: 0x13ff259  [node]
[2]    802902 abort      node

Additional information

@Ayase-252 Ayase-252 added the perf_hooks Issues and PRs related to the implementation of the Performance Timing API. label Apr 9, 2021
@aduh95
Copy link
Contributor

aduh95 commented Apr 9, 2021

Can reproduce on master.

@aduh95 aduh95 added the confirmed-bug Issues with confirmed bugs. label Apr 9, 2021
aduh95 added a commit to aduh95/node that referenced this issue Apr 9, 2021
@Flarna Flarna closed this as completed in 548cbf0 Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed-bug Issues with confirmed bugs. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants