Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nominating @Linkgoron as collaborator #37619

Closed
benjamingr opened this issue Mar 6, 2021 · 6 comments · Fixed by #37817
Closed

Nominating @Linkgoron as collaborator #37619

benjamingr opened this issue Mar 6, 2021 · 6 comments · Fixed by #37817
Labels
meta Issues and PRs related to the general management of the project.

Comments

@benjamingr
Copy link
Member

I would like to nominate @Linkgoron for collaborator. He has been doing a lot of good work in AbortController, streams and a few others and his reviews are always useful. I believe he has demonstrated competence in the codebase and honestly it would be a big help if he could run CI and land things himself.

Pull Requests and issues in Node.js: https://github.com/nodejs/node/issues?q=author:linkgoron
Commits in Node.js: https://github.com/nodejs/node/commits?author=Linkgoron
Comments in Node.js: https://github.com/nodejs/node/issues?q=commenter:Linkgoron

@nodejs/collaborators
@benjamingr benjamingr added the meta Issues and PRs related to the general management of the project. label Mar 6, 2021
@vdeturckheim
Copy link
Member

👍 for me

@Linkgoron
Copy link
Member

Thanks for the nomination, this is a real honor for me!

@mhdawson
Copy link
Member

mhdawson commented Mar 8, 2021

+1

@benjamingr
Copy link
Member Author

@nodejs/tsc looks like we need someone from the TSC to schedule an onboarding session 🎉

@benjamingr
Copy link
Member Author

Maybe @Trott if he is up for it since they collaborated on stuff together?

@Trott
Copy link
Member

Trott commented Mar 14, 2021

Maybe @Trott if he is up for it since they collaborated on stuff together?

I've sent an email to try to work out a time.

Linkgoron added a commit to Linkgoron/node that referenced this issue Mar 19, 2021
@Linkgoron
doc: add @Linkgoron to collaborators
1531e20 
fixes: nodejs#37619
Linkgoron added a commit to Linkgoron/node that referenced this issue Mar 19, 2021
@Linkgoron
doc: add @Linkgoron to collaborators
3f61c7e 
fixes: nodejs#37619
@Linkgoron Linkgoron mentioned this issue Mar 19, 2021
Merged
ruyadorno pushed a commit that referenced this issue Mar 24, 2021
@Linkgoron @ruyadorno
doc: add @Linkgoron to collaborators
4700042 
fixes: #37619

PR-URL: #37817
Fixes: #37619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos pushed a commit that referenced this issue May 1, 2021
@Linkgoron @targos
doc: add @Linkgoron to collaborators
b2d3ac8 
fixes: #37619

PR-URL: #37817
Fixes: #37619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add @linkgoron to collaborators Linkgoron/node
5 participants
@Trott @Linkgoron @benjamingr @vdeturckheim @mhdawson