Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate flaky test-repl-history-navigation #37222

Closed
RaisinTen opened this issue Feb 4, 2021 · 1 comment · Fixed by #37223
Closed

investigate flaky test-repl-history-navigation #37222

RaisinTen opened this issue Feb 4, 2021 · 1 comment · Fixed by #37223
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Comments

@RaisinTen
Copy link
Contributor

RaisinTen commented Feb 4, 2021 •
edited
Loading 

19:29:04 not ok 499 parallel/test-repl-history-navigation
19:29:04   ---
19:29:04   duration_ms: 17.21
19:29:04   severity: fail
19:29:04   exitcode: 1
19:29:04   stack: |-
19:29:04     node:internal/timers:558
19:29:04               timer._onTimeout(...args);
19:29:04                                   ^
19:29:04     
19:29:04     TypeError: Found non-callable @@iterator
19:29:04         at listOnTimeout (node:internal/timers:558:17)
19:29:04         at processTimers (node:internal/timers:499:7)
19:29:04   ...
RaisinTen added a commit to RaisinTen/node that referenced this issue Feb 4, 2021
@RaisinTen
timers: fix unsafe array iteration
f5173ba 
Fixes: nodejs#37222
@RaisinTen RaisinTen mentioned this issue Feb 4, 2021
Merged
@RaisinTen RaisinTen added flaky-test Issues and PRs related to the tests with unstable failures on the CI. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Feb 4, 2021
@RaisinTen
Copy link
Contributor Author

cc @nodejs/timers

@Trott Trott closed this as completed in c0e66e3 Feb 6, 2021
danielleadams pushed a commit that referenced this issue Feb 16, 2021
@RaisinTen @danielleadams
timers: fix unsafe array iteration
dc38dd2 
Fixes: #37222

PR-URL: #37223
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue May 27, 2021
@RaisinTen @targos
timers: fix unsafe array iteration
04bfa07 
Fixes: #37222

PR-URL: #37223
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue May 30, 2021
@RaisinTen @targos
timers: fix unsafe array iteration
a9483c3 
Fixes: #37222

PR-URL: #37223
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue Jun 5, 2021
@RaisinTen @targos
timers: fix unsafe array iteration
1a56217 
Fixes: #37222

PR-URL: #37223
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue Jun 11, 2021
@RaisinTen @targos
timers: fix unsafe array iteration
1dc7fd2 
Fixes: #37222

PR-URL: #37223
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

timers: fix unsafe array iteration RaisinTen/node
1 participant
@RaisinTen