Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: dead code #36199

Closed
mscdex opened this issue Nov 20, 2020 · 2 comments
Closed

benchmark: dead code #36199

mscdex opened this issue Nov 20, 2020 · 2 comments
Labels
benchmark Issues and PRs related to the benchmark subsystem. fs Issues and PRs related to the fs subsystem / file system.

Comments

@mscdex
Copy link
Contributor

mscdex commented Nov 20, 2020

  • Version: master
  • Platform: n/a
  • Subsystem: benchmark

In benchmark/fs/bench-statSync.js, the

  if (statSyncType === 'fstat')
    fs.closeSync(arg);

should instead be

  if (statSyncType === 'fstatSync')
    fs.closeSync(arg);

Although, I'm not sure we even need that bit of code since the OS will automatically clean up any open resources on process exit.

@mscdex mscdex added fs Issues and PRs related to the fs subsystem / file system. benchmark Issues and PRs related to the benchmark subsystem. good first issue Issues that are suitable for first-time contributors. labels Nov 20, 2020
@ntedgi
Copy link
Contributor

ntedgi commented Nov 21, 2020

hi I would like to work on this one

@Trott
Copy link
Member

Trott commented Nov 23, 2020

Removing good first issue because we now have at least 2 PRs that address this.

@Trott Trott removed the good first issue Issues that are suitable for first-time contributors. label Nov 23, 2020
danielleadams pushed a commit that referenced this issue Dec 7, 2020
PR-URL: #36206
Fixes: #36199
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue May 1, 2021
PR-URL: #36206
Fixes: #36199
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants