investigate flaky benchmark/test-benchmark-misc

[gireeshpunathil]

https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_withoutintl_x64/23249/console

17:32:16 not ok 3025 benchmark/test-benchmark-misc
17:32:16   ---
17:32:16   duration_ms: 0.932
17:32:16   severity: fail
17:32:16   exitcode: 1
17:32:16   stack: |-
17:32:16     ------ stdout ------
17:32:16     
17:32:16     ------ stderr ------
17:32:16     node:inspector:25
17:32:16       throw new ERR_INSPECTOR_NOT_AVAILABLE();
17:32:16       ^
17:32:16     
17:32:16     Error [ERR_INSPECTOR_NOT_AVAILABLE]: Inspector is not available
17:32:16         at new NodeError (node:internal/errors:259:15)
17:32:16         at node:inspector:25:9
17:32:16         at NativeModule.compileForInternalLoader (node:internal/bootstrap/loaders:278:7)
17:32:16         at NativeModule.compileForPublicLoader (node:internal/bootstrap/loaders:220:10)
17:32:16         at loadNativeModule (node:internal/modules/cjs/helpers:35:9)
17:32:16         at Function.Module._load (node:internal/modules/cjs/loader:760:15)
17:32:16         at Module.require (node:internal/modules/cjs/loader:972:19)
17:32:16         at require (node:internal/modules/cjs/helpers:88:18)
17:32:16         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/benchmark/fixtures/require-builtins.js:45:3)
17:32:16         at Module._compile (node:internal/modules/cjs/loader:1083:30) {
17:32:16       code: 'ERR_INSPECTOR_NOT_AVAILABLE'
17:32:16     }
17:32:16     
17:32:16     /home/iojs/build/workspace/node-test-commit-linux-containered/benchmark/misc/startup.js:49
17:32:16           throw new Error(`Error during node startup, exit code ${code}`);
17:32:16           ^
17:32:16     
17:32:16     Error: Error during node startup, exit code 1
17:32:16         at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/benchmark/misc/startup.js:49:13)
17:32:16         at ChildProcess.emit (node:events:327:20)
17:32:16         at Process.ChildProcess._handle.onexit (node:internal/child_process:277:12)
17:32:16     node:assert:107
17:32:16       throw new AssertionError(obj);
17:32:16       ^
17:32:16     
17:32:16     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
17:32:16     
17:32:16     1 !== 0
17:32:16     
17:32:16         at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/common/benchmark.js:30:12)
17:32:16         at ChildProcess.emit (node:events:327:20)
17:32:16         at Process.ChildProcess._handle.onexit (node:internal/child_process:277:12) {
17:32:16       generatedMessage: true,
17:32:16       code: 'ERR_ASSERTION',
17:32:16       actual: 1,
17:32:16       expected: 0,
17:32:16       operator: 'strictEqual'
17:32:16     }
17:32:16   ...

[richardlau]

The new benchmark added in #35816 is broken when Node.js is compiled with --without-intl as some of the modules it requires will throw in that configuration. Unfortunately it looks like that PR landed with a failing CI.

Raised #35968 to fix.

[gireeshpunathil]

Unfortunately it looks like that PR landed with a failing CI.

@richardlau - IIUC commit-queue action fails if the most recent / relevant CI was a failure, am I right?

[richardlau]

Unfortunately it looks like that PR landed with a failing CI.

@richardlau - IIUC commit-queue action fails if the most recent / relevant CI was a failure, am I right?

Yes. It uses git node land from node-core-utils which should also have warned if it had been used.