-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto pbkdf2 keylen: bits or bytes? #3415
Comments
silverwind
added
crypto
Issues and PRs related to the crypto subsystem.
doc
Issues and PRs related to the documentations.
labels
Oct 17, 2015
This would be fixed by #3334 I think. |
Definitely. Apparently I missed that one during my search. |
I think this can be closed then, as it was landed in ff8fa51. |
lboecker
pushed a commit
to lboecker/node
that referenced
this issue
Oct 14, 2017
512 bytes seems a lot. See nodejs#3415
addaleax
pushed a commit
to ayojs/ayo
that referenced
this issue
Oct 18, 2017
PR-URL: nodejs/node#16203 Refs: nodejs/node#3415 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The api docs use 512 for the keylen:
But they don't mention whether the keylen is in bits or bytes.
Given the fact that it has a value of 512 I would expect it to be in bits, but the end result seems to generate a key of 512 bytes
Some clarification would be welcome
The text was updated successfully, but these errors were encountered: