Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: bug in fs module autocompletion #29424

Closed
ZYSzys opened this issue Sep 3, 2019 · 6 comments
Closed

repl: bug in fs module autocompletion #29424

ZYSzys opened this issue Sep 3, 2019 · 6 comments
Labels
confirmed-bug Issues with confirmed bugs. good first issue Issues that are suitable for first-time contributors. repl Issues and PRs related to the REPL subsystem.

Comments

@ZYSzys
Copy link
Member

ZYSzys commented Sep 3, 2019 •
edited
Loading

  • Version: master
  • Platform: macOS X 10.14.4
  • Subsystem: repl

Small bug on macOS (when, e.g., I have node-core-utils in /Users/Projects):

fs.readFileSync('node-<tab>

EXPECTED: fs.readFileSync('node-core-utils
ACTUAL:   fs.readFileSync('node-ode-core-utils

Refs: #26648 (comment)

cc @antsmartian
@ZYSzys ZYSzys added the repl Issues and PRs related to the REPL subsystem. label Sep 3, 2019
@Fishrock123 Fishrock123 added the good first issue Issues that are suitable for first-time contributors. label Sep 5, 2019
@Fishrock123
Copy link
Contributor

For me, pressing tab in this scenario results in fs.readFileSync('node-ode- and refuses to go further.

@Fishrock123 Fishrock123 added the confirmed-bug Issues with confirmed bugs. label Sep 5, 2019
@joao-alberto
Copy link

Can I work in this issue?

@juanarbol
Copy link
Member

@joao-alberto Do it!

@lholmquist
Copy link
Contributor

lholmquist commented Sep 11, 2019 •
edited
Loading

I can also confirm that this issue is present on Fedora 29 using Node 12.9.0

@antsmartian
Copy link
Contributor

I know what is causing this issue, I guess. Let me work on a fix. @joao-alberto Let me know if you have picked up this issue?

@joao-alberto
Copy link

@antsmartian If you already know the issue go ahead. Let me know if you need some help.

@ZYSzys ZYSzys mentioned this issue Sep 14, 2019
Closed
3 tasks
@ZYSzys ZYSzys closed this as completed in 2f497a6 Sep 18, 2019
targos pushed a commit that referenced this issue Sep 20, 2019
@targos
repl: fix bug in fs module autocompletion
93ce43e 
PR-URL: #29555
Fixes: #29424
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this issue Sep 25, 2019
@BridgeAR
repl: fix bug in fs module autocompletion
7eae707 
PR-URL: #29555
Fixes: #29424
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. good first issue Issues that are suitable for first-time contributors. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

repl: fix bug in fs module autocompletion zys-contrib/node
6 participants
@lholmquist @Fishrock123 @antsmartian @joao-alberto @juanarbol @ZYSzys