Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs vm.SourceTextModule: Instantiate() abstract operation has been replaced with InitializeEnvironment() #29030

Closed
Jamesernator opened this issue Aug 7, 2019 · 1 comment
Closed

docs vm.SourceTextModule: Instantiate() abstract operation has been replaced with InitializeEnvironment() #29030

Jamesernator opened this issue Aug 7, 2019 · 1 comment
Assignees
@devsnek
Labels
vm Issues and PRs related to the vm subsystem.

Comments

@Jamesernator
Copy link

The docs for vm.SourceTextModule.prototype.instantiate() contain a link to Instantiate() however this abstract method has been replaced with InitializeEnvironment() and so the link is now broken (it now points to Link()).

It might be worth renaming the .instantiate() method to .initializeEnvironment(), but regardless a doc update needs to be made to point to initialize environment.
@devsnek devsnek added the vm Issues and PRs related to the vm subsystem. label Aug 7, 2019
@devsnek
Copy link
Member

devsnek commented Aug 7, 2019

I will update this

@devsnek devsnek self-assigned this Sep 9, 2019
devsnek added a commit to devsnek/node that referenced this issue Sep 9, 2019
@devsnek
vm: SourceTextModule refactor
cbcdd96 
- Removes redundant `instantiate` method
- Refactors `link` to match the spec linking steps more accurately
- Removes URL validation from SourceTextModule specifiers
- DRYs some dynamic import logic

Closes nodejs#29030
@devsnek devsnek mentioned this issue Sep 30, 2019
Closed
4 tasks
devsnek added a commit to devsnek/node that referenced this issue Oct 1, 2019
@devsnek @targos
vm: refactor SourceTextModule
c002456 
- Removes redundant `instantiate` method
- Refactors `link` to match the spec linking steps more accurately
- Removes URL validation from SourceTextModule specifiers
- DRYs some dynamic import logic

Closes nodejs#29030

Co-Authored-By: Michaël Zasso <targos@protonmail.com>
@Trott Trott closed this as completed in 5e7946f Oct 2, 2019
BridgeAR pushed a commit that referenced this issue Oct 9, 2019
@devsnek @BridgeAR
vm: refactor SourceTextModule
6d88f0f 
- Removes redundant `instantiate` method
- Refactors `link` to match the spec linking steps more accurately
- Removes URL validation from SourceTextModule specifiers
- DRYs some dynamic import logic

Closes: #29030

Co-Authored-By: Michaël Zasso <targos@protonmail.com>

PR-URL: #29776
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devsnek devsnek

Labels
vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vm: SourceTextModule refactor devsnek/node
2 participants
@devsnek @Jamesernator