Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2.connect is Not Accepting IPv6 Addresses #28216

Closed
anliting opened this issue Jun 13, 2019 · 0 comments
Closed

http2.connect is Not Accepting IPv6 Addresses #28216

anliting opened this issue Jun 13, 2019 · 0 comments
Labels
http2 Issues or PRs related to the http2 subsystem.

Comments

@anliting
Copy link

let
    http2=require('http2'),
    server=http2.createServer()
server.listen(8000,'::1',()=>{
    http2.connect('http://[::1]:8000',()=>{
        console.log('listener called')
    })
})

Expected: console.log('listener called')
Result: Error: getaddrinfo ENOTFOUND [::1] [::1]:8000

@lpinca lpinca added the http2 Issues or PRs related to the http2 subsystem. label Jun 24, 2019
lpinca added a commit to lpinca/node that referenced this issue Jun 24, 2019
Make `http2.connect()` work when using URLs with literal IPv6
addresses.

Fixes: nodejs#28216
@lpinca lpinca closed this as completed in 26b048e Jul 1, 2019
targos pushed a commit that referenced this issue Jul 2, 2019
Make `http2.connect()` work when using URLs with literal IPv6
addresses.

Fixes: #28216

PR-URL: #28406
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos pushed a commit that referenced this issue Jul 2, 2019
Make `http2.connect()` work when using URLs with literal IPv6
addresses.

Fixes: #28216

PR-URL: #28406
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants