Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intl: ICU download retry, backup urls #2746

Closed
srl295 opened this issue Sep 8, 2015 · 10 comments
Closed

Intl: ICU download retry, backup urls #2746

srl295 opened this issue Sep 8, 2015 · 10 comments
Labels
i18n-api Issues and PRs related to the i18n implementation.

Comments

@srl295
Copy link
Member

srl295 commented Sep 8, 2015

See nodejs/node-v0.x-archive#9184

  • support 'backup URLs'
  • retry on failure
@srl295 srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Sep 8, 2015
@srl295 srl295 self-assigned this Sep 8, 2015
@jbergstroem
Copy link
Member

According to Steven, as of a few hours ago this should have been fixed.

@jbergstroem
Copy link
Member

As for retry on failure, thats easier said than done with urllib. How about we close this for now? I'm looking at using wget/curl where possible as an alternate solution.

@srl295
Copy link
Member Author

srl295 commented Sep 10, 2015

Johan- I'd like to support backup urls at least to handle 404s. Or could
wget/curl (where available??) be part of this issue? Not sure why this
needs to be closed exactly- I'm trying to capture the original sentiment
from Joyent/node

El miércoles, 9 de septiembre de 2015, Johan Bergström <
notifications@github.com> escribió:

As for retry on failure, thats easier said than done with urllib. How
about we close this for now? I'm looking at using wget/curl where possible
as an alternate solution.


Reply to this email directly or view it on GitHub
#2746 (comment).

@jbergstroem
Copy link
Member

@srl295 sorry - I thought the issue was about getting it mirrored through sourceforge which you mentioned was accomplished the other day. Feel free to keep it open.

As for hte replacement of nodedownload.py, its a work in progress on my local machine for now.

@srl295
Copy link
Member Author

srl295 commented Oct 5, 2015

.. Also, don't output the following if stdout isn't a TTY

 Fetch: ' 26.4MB total, 1.0MB downloaded   
 Fetch: . 26.4MB total, 1.0MB downloaded   
 Fetch: : 26.4MB total, 1.0MB downloaded   
 Fetch: | 26.4MB total, 1.0MB downloaded   
 Fetch: ' 26.4MB total, 1.0MB downloaded   
 Fetch: . 26.4MB total, 1.0MB downloaded   
 Fetch: : 26.4MB total, 1.0MB downloaded   
 Fetch: | 26.4MB total, 1.0MB downloaded   
 Fetch: ' 26.4MB total, 1.0MB downloaded   
 Fetch: . 26.4MB total, 1.0MB downloaded   
 Fetch: : 26.4MB total, 1.0MB downloaded   
 Fetch: | 26.4MB total, 1.0MB downloaded   
 Fetch: ' 26.4MB total, 1.0MB downloaded   
 Fetch: . 26.4MB total, 1.1MB downloaded   
 Fetch: : 26.4MB total, 1.1MB downloaded   
 Fetch: | 26.4MB total, 1.1MB downloaded   
 Fetch: ' 26.4MB total, 1.1MB downloaded   
 Fetch: . 26.4MB total, 1.1MB downloaded   
 Fetch: : 26.4MB total, 1.1MB downloaded   
 Fetch: | 26.4MB total, 1.1MB downloaded   
 Fetch: ' 26.4MB total, 1.1MB downloaded   
 Fetch: . 26.4MB total, 1.1MB downloaded   
 Fetch: : 26.4MB total, 1.1MB downloaded   
 Fetch: | 26.4MB total, 1.1MB downloaded   

@srl295 srl295 removed their assignment Oct 5, 2015
@srl295
Copy link
Member Author

srl295 commented Oct 6, 2015

@jbergstroem wget/curl would at least have a retry option.

@jasnell
Copy link
Member

jasnell commented Apr 22, 2016

Does this need to stay open?

@jbergstroem
Copy link
Member

An actionable item would be switching to wget/curl. I started on this a good while ago but never finished. Feel free to close from my part.

@srl295
Copy link
Member Author

srl295 commented Apr 24, 2016

Basically moot by #6088

Enviado desde nuestro iPhone.

El abr 22, 2016, a las 10:24 PM, Johan Bergström notifications@github.com escribió:

An actionable item would be switching to wget/curl. I started on this a good while ago but never finished. Feel free to close from my part.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@srl295
Copy link
Member Author

srl295 commented May 3, 2016

I'm going to close this, because with #6088 ICU is not downloaded unless full ICU is requested - it's a nice-to-have, but most people won't see it unless they turn on full ICU. We can always reopen it if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Development

No branches or pull requests

3 participants