Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console.trace in 11.13.0 has an extra line #27134

Closed
LinusU opened this issue Apr 8, 2019 · 1 comment
Closed

console.trace in 11.13.0 has an extra line #27134

LinusU opened this issue Apr 8, 2019 · 1 comment
Labels
console Issues and PRs related to the console subsystem.

Comments

@LinusU
Copy link
Contributor

LinusU commented Apr 8, 2019

  • Version: 11.13.0
  • Platform: macOS
  • Subsystem: console

It seems like this fix (#26764) added an extra line at the top of the trace which wasn't there before.

v11.10.0:

$ nvm use 11.10.0    
Now using node v11.10.0 (npm v6.7.0)
$ node           
> console.trace('a')
Trace: a
    at repl:1:9
    at Script.runInThisContext (vm.js:124:20)
    at REPLServer.defaultEval (repl.js:322:29)
    at bound (domain.js:400:14)
    at REPLServer.runBound [as eval] (domain.js:413:12)
    at REPLServer.onLine (repl.js:632:10)
    at REPLServer.emit (events.js:202:15)
    at REPLServer.EventEmitter.emit (domain.js:446:20)
    at REPLServer.Interface._onLine (readline.js:308:10)
    at REPLServer.Interface._line (readline.js:654:8)                                                       

v11.13.0:

$ nvm use 11.13.0 
Now using system version of node: v11.13.0 (npm v6.7.0)
$ node
> console.trace('a')
Trace: a
    at Console.trace (internal/console/constructor.js:336:11)
    at repl:1:9
    at Script.runInThisContext (vm.js:124:20)
    at REPLServer.defaultEval (repl.js:325:29)
    at bound (domain.js:425:14)
    at REPLServer.runBound [as eval] (domain.js:438:12)
    at REPLServer.onLine (repl.js:650:10)
    at REPLServer.emit (events.js:198:15)
    at REPLServer.EventEmitter.emit (domain.js:481:20)
    at REPLServer.Interface._onLine (readline.js:308:10)
@targos
Copy link
Member

targos commented Apr 8, 2019

@BridgeAR

BridgeAR added a commit to BridgeAR/node that referenced this issue Apr 9, 2019
The own function's frame was removed originally. This restors that
behavior.

Fixes: nodejs#27134
@BridgeAR BridgeAR added the console Issues and PRs related to the console subsystem. label Apr 9, 2019
@ZYSzys ZYSzys closed this as completed in 091902a Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console Issues and PRs related to the console subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants