Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate flaky test-net-connect-handle-econnrefused #26907

Closed
Trott opened this issue Mar 25, 2019 · 0 comments
Closed

investigate flaky test-net-connect-handle-econnrefused #26907

Trott opened this issue Mar 25, 2019 · 0 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. net Issues and PRs related to the net subsystem.

Comments

@Trott
Copy link
Member

Trott commented Mar 25, 2019

https://ci.nodejs.org/job/node-test-commit-linux/26401/nodes=debian8-64/console

test-rackspace-debian8-x64-1

11:09:03 not ok 1277 parallel/test-net-connect-handle-econnrefused
11:09:03   ---
11:09:03   duration_ms: 0.143
11:09:03   severity: fail
11:09:03   exitcode: 1
11:09:03   stack: |-
11:09:03     assert.js:129
11:09:03       throw err;
11:09:03       ^
11:09:03     
11:09:03     AssertionError [ERR_ASSERTION]: function should not have been called at /home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64/test/parallel/test-net-connect-handle-econnrefused.js:32
11:09:03         at Socket.mustNotCall (/home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64/test/common/index.js:416:12)
11:09:03         at Socket.emit (events.js:194:13)
11:09:03         at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1046:10)
11:09:03   ...
@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. net Issues and PRs related to the net subsystem. labels Mar 25, 2019
lpinca added a commit to lpinca/node that referenced this issue Mar 30, 2019
@lpinca
test: move test-net-connect-handle-econnrefused
c1c2b5c 
The port used in the test could be taken by another process before
the callback of `server.close()` is called. Move it to sequential.

Refs: nodejs#18257 (comment)
Fixes: nodejs#26907
@lpinca lpinca closed this as completed in f7afed1 Apr 27, 2019
targos pushed a commit that referenced this issue Apr 27, 2019
@lpinca @targos
test: move test-net-connect-handle-econnrefused
e9021cc 
The port used in the test could be taken by another process before
the callback of `server.close()` is called. Move it to sequential.

PR-URL: #27014
Fixes: #26907
Refs: #18257 (comment)
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Trott