Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_event_information missing argument response <http.IncomingMessage> #26905

Closed
codepilot opened this issue Mar 25, 2019 · 1 comment
Closed
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.

Comments

@codepilot
Copy link

  • Version: v11.12.0 and v10.15.3
  • Platform: documentation
  • Subsystem: HTTP event information

http event information is missing argument response <http.IncomingMessage> in the documentation found at nodejs documentation http_event_information, but the example has an example of a response argument

@lpinca lpinca added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. labels Mar 27, 2019
@lpinca
Copy link
Member

lpinca commented Mar 27, 2019

It is actually a plain object and not an IncomingMessage instance.

req.emit('information', { statusCode: res.statusCode });

lpinca added a commit to lpinca/node that referenced this issue Mar 30, 2019
- Add missing argument
- Reword a sentence
- Rename the `res` argument to `info` in the example to avoid confusion

Fixes: nodejs#26905
@danbev danbev closed this as completed in 0a5a762 Apr 2, 2019
BethGriggs pushed a commit that referenced this issue Apr 5, 2019
- Add missing argument
- Reword a sentence
- Rename the `res` argument to `info` in the example to avoid confusion

PR-URL: #27009
Fixes: #26905
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BethGriggs pushed a commit that referenced this issue Apr 9, 2019
- Add missing argument
- Reword a sentence
- Rename the `res` argument to `info` in the example to avoid confusion

PR-URL: #27009
Fixes: #26905
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this issue Apr 9, 2019
- Add missing argument
- Reword a sentence
- Rename the `res` argument to `info` in the example to avoid confusion

PR-URL: #27009
Fixes: #26905
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this issue Apr 10, 2019
- Add missing argument
- Reword a sentence
- Rename the `res` argument to `info` in the example to avoid confusion

PR-URL: #27009
Fixes: #26905
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants